Change session tab shortcuts to fix AltGr problem

[vinicentus]

Update so that the shortcut doesn't interfere with AltGr shortcuts as seen here: #12956. This would also change the shortcuts to Cmd + Alt + partitionNumber for MacOS and Ctrl + Shift + partitionNumber for Windows and Linux.

I personally think this is a better shortcut since it's easier to do with only one hand (at least on Windows and Linux).

The original problem comes from here #6915

NOTE: The shortcuts also need to be changed like seen here #13000, but I couldn't find it in the code.
Fixes #13000

Fixes #12956

Submitter Checklist:

• Submitted a ticket for my issue if one did not already exist.
• Used Github auto-closing keywords in the commit message.
• Added/updated tests for this change (for new code or code which already has tests).
• Ran git rebase -i to squash commits (if needed).
• Tagged reviewers and labelled the pull request as needed.
• Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

Reviewer Checklist:

• Request a security/privacy review as needed if one was not already requested.

Tests

• Adequate test coverage exists to prevent regressions
• Tests should be independent and work correctly when run individually or as a suite ref
• New files have MPL2 license header

[vinicentus]

Compiled it myself and tested it out. Seems to be working as it should. tested on windows only.

SUGGESTION: Make Windows use Control + Shift and MacOS use Command + Opition, what do you think?

[luixxiul]

Just curious, is the proposed change following de facto standard?

[vinicentus]

Just curious, is the proposed change following de facto standard?

If you are talking about shortcut standard I'd say it does, at least on Windows and Linux, somebody please help me out with MacOS ;-) My reasoning for this is that Ctrl + something and Ctrl + Shift + something is often used for tabs.

[vinicentus]

It would then look like this

[petemill]

Thanks for your pull request @vinicentus! Unfortunately we cannot accept it at this time since cmd-shift-[number] will interfere with macOS global shortcuts for screenshots. Until we find something suitable, I'm going to revert #10364 and remove the new shortcut entirely in order to fix user's input issues as soon as possible.

[vinicentus]

How about this:
accelerator: isDarwin ? 'CmdOrCtrl+Alt+' + partitionNumber : 'Ctrl+Shift+' + partitionNumber,

Then it would be Cmd + Alt + partitionNumber for MacOS and Ctrl + Shift + partitionNumber for Windows and Linux.

EDIT: Nevermind, the problem persists on MacOS... What could be a better shortcut? Should I open a new issue?
EDIT 2: Shouldn't this work though? Correct me if I'm wrong

[codecov-io]

Codecov Report

Merging #13015 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #13015      +/-   ##
==========================================
+ Coverage   56.13%   56.16%   +0.02%     
==========================================
  Files         279      279              
  Lines       27332    27352      +20     
  Branches     4446     4452       +6     
==========================================
+ Hits        15343    15362      +19     
- Misses      11989    11990       +1

Flag	Coverage Δ
#unittest	56.16% <100%> (+0.02%)	⬆️

Impacted Files	Coverage Δ
app/common/commonMenu.js	52.5% <100%> (+0.29%)	⬆️
app/cmdLine.js	39.8% <0%> (+12.42%)	⬆️

[vinicentus]

Opening a new issue for this...