Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Using temporarySiteSettings to store private tab preferences #4469

Merged
merged 3 commits into from
Oct 4, 2016
Merged

Using temporarySiteSettings to store private tab preferences #4469

merged 3 commits into from
Oct 4, 2016

Commits on Oct 3, 2016

  1. Using temporarySiteSettings to store private tab preferences 

    fix #4468

Auditors: @bbondy, @bridiver

Test Plan:
Test bravery panel, site permissions, mixed content, flash in private tabs and the preferences should not write to disk and affect regular tabs
    @darkdh
    darkdh committed Oct 3, 2016
    Configuration menu
    Copy the full SHA
    b347a96 View commit details
    Browse the repository at this point in the history

  2. 1. Do not override siteSettings on regular session 

    2. Inherit settings from regular session on private session
    @darkdh
    darkdh committed Oct 3, 2016
    4 Configuration menu
    Copy the full SHA
    7de0c05 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2016

  1. Using mergeDeep to override regular site setttings on private session

    @darkdh
    darkdh committed Oct 4, 2016
    Configuration menu
    Copy the full SHA
    84f436d View commit details
    Browse the repository at this point in the history