This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Update sortableTable styles to be consistent #4509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Preferences > search no longer has cell padding (matches history) - Preferences > search columns resized to allow for up/down chevron (sort) - All: updated new th-inner style added w/ #4395 to be inline-block to allow for up/down chevron (sort) - removes border radius from top left and top right (didn't look correct anymore with the new 1px border on top) - styles now mark headers on preferences as non-selectable and leaves cursor as default (to remain app-like) Fixes #4492 Fixes #4493 Auditors: @bbondy @bradleyrichter Test Plan: 1) Launch Brave and open history- check out styles 2) Open preferences and check out styles on Search page 3) Check out styles on Payments page
bsclifton
commented
Oct 4, 2016
| } | ||
| } | ||
| } | ||
| height: 500px; |
There was a problem hiding this comment.
this was MOSTLY just a spacing issue (everything was off by 1 space; git didn't intelligently realize that)
|
great screenshots, thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -ito squash commits (if needed).Update sortableTable styles to be consistent
Fixes #4492
Fixes #4493
Auditors: @bbondy @bradleyrichter
Test Plan
3) Check out styles on Payments page
Screenshots (the important part!)
Search screen updates (#4493)
Before
After
Fixing the column style issue (#4492)
Before
After
Border radius update
Before
N/A- style was changed when fixing #4493
After (zoomed in to show pixels)
Updates to text selection
Screenshots show what happens if you click and drag to try to select all text on the screen
Before
After
