Made the new tab button touch screen friendly #5927
Conversation
|
work in progress :-) |
|
ok, ready for review. |
Fixes #5925 Auditors: @bsclifton Test Plan: make sure clicking is expanded enough
| -webkit-mask-image: url('../img/toolbar/newtab_btn.svg'); | ||
| -webkit-mask-repeat: no-repeat; | ||
| -webkit-mask-position: center; | ||
| -webkit-mask-size: 12px 12px; |
There was a problem hiding this comment.
the plus image is 12x12 and centered, increasing the height of the button (which is clickable) to 24px.
|
@jkup would you be able to review this? edit: I'm curious if it'll work as expected with width/height both set, instead of using width and max-height. I remember having to do that because certain resolutions would contort the SVG |
|
Yep I'll review now. |
|
Awesome! I'll try the Windows version... |
|
++ from me This approach is cool, I didn't know about it! Although I'm not really able to repro the initial issue on my Mac so hopefully @bsclifton can merge if the original issue is fixed on Windows! |
|
Looks great 😄 Awesome job, @luixxiul! Screenshot of the hitbox, so everybody can see. It now extends all the way up and down |
luixxiul
added
QA/no-qa-needed
release-notes/exclude
and removed
QA/checked-Win32
release-notes/exclude
labels
|
Labelled |
git rebase -ito squash commits (if needed).Fixes #5925
Auditors: @bsclifton
Test Plan: make sure clicking is expanded enough