Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Remove border around new tab button; also increases width of button #6474

Merged
merged 1 commit into from
Dec 30, 2016
Merged

Remove border around new tab button; also increases width of button #6474

merged 1 commit into from
Dec 30, 2016

Conversation

bsclifton
Copy link
Member

@bsclifton bsclifton commented Dec 30, 2016

Remove border around new tab button; also increases width of button making it much easier to click)

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Fixes #6467
Also fixes #6125

Regression was caused by the combination of these two commits:
010e708
615a6ec

Auditors: @bbondy, @bradleyrichter

How it looks with these changes

Hitbox is now 25 wide by 25 tall, instead of 15 wide by 25 tall
screen shot 2016-12-30 at 10 53 02 am

mini-video of it in action
new-tab-button

How it looked before these changes

comparison to the old one (crowd boos):
screen shot 2016-12-09 at 5 22 07 pm

and for good measure, here's the border issue that this fixes (which I could only repro on Windows at > 100% DPI):
image

…making it much easier to click)

Fixes #6467
Also fixes #6125

Regression was caused by the combination of these two commits:
010e708
615a6ec

Auditors: @bbondy, @bradleyrichter
@bsclifton
Copy link
Member Author

@bradleyrichter added!

@bsclifton bsclifton added this to the 0.13.0 milestone Dec 30, 2016
Copy link
Contributor

@bradleyrichter bradleyrichter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed on Mac. Looks good. Nice large hit area while retaining previous icon size.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants