LPS-115485 As a developer I can inject custom CSS variables declaring an OSGi component #90496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lues All instances of ScopedCSSVariablesProvider will be queried whenever a page's HTML is rendered to gather all the ScopedCSSVariables that must be injected in the page. A ScopedCSSVariables object defines a set of CSS variable values tied to a given CSS scope (f.e: :root, body, etc...)
…viders This DynamicInclude renders all ScopedCSSVariables in the <head> tag of the page's HTML right after the theme's CSS links are injected.
|
To conserve resources, the PR Tester does not automatically run for forwarded pull requests. |
|
Merged. Thank you. |
|
Wow @izaera very nice. No changes in Java for me. modules/apps/frontend-css/frontend-css-variables-web/src/test/resources/com/liferay/frontend/css/variables/web/internal/servlet/taglib/liferay_css_variables_1.html Can we indent the CSS in the HTML or is the bad formatting on purpose? Please send a follow up pull if we can indent. |
Closed
liferay-continuous-integration
deleted the
ci-forward-LPS-115485-pr-21-sender-izaera-ts-1592905162235
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forwarded from: liferay-frontend#21 (Took 1
ci:forwardattempt in 4 minutes)@izaera
@liferay-frontend
Original pull request comment:
Previously: https://github.com/wincent/liferay-portal/pull/354
Moving it here and will try to get a green
ci:test:relevantrun out of it.cc @izaera
Original description follows:
This is a partial PR based on the original PoC https://github.com/jbalsas/liferay-portal/pull/2211. This implements the Frontend Infrastructure DynamicInclude part only, and provides tests for it.
Note that there's no way to test this from the GUI.
✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes
Click here for more details.
Base Branch:
Branch Name: master
Branch GIT ID: ee8af6d3c052b2e98f267e2ca397582fa816f1a7
Sender Branch:
Branch Name: LPS-115485
1 out of 1jobs PASSEDBranch GIT ID: 248e439a6eda313be4666ef7a416c781ad5d97a5
1 Successful Jobs:
For more details click here.
✔️ ci:test:stable - 20 out of 20 jobs passed
✔️ ci:test:relevant - 49 out of 49 jobs passed in 1 hour 23 minutes
Click here for more details.
Base Branch:
Branch Name: master
Branch GIT ID: d7b659d0c9f0278aae1e7b580e59e6ce90ffb59d
Copied in Private Modules Branch:
Branch Name: master-private
Branch GIT ID: 1eb935eac6911217dfe48eb2379d11fb23dd7f33
ci:test:stable - 20 out of 20 jobs PASSED
20 Successful Jobs:
ci:test:relevant - 49 out of 49 jobs PASSED
49 Successful Jobs:
For more details click here.