Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-115485 Format CSS #51

Closed
wants to merge 2 commits into from
Closed

LPS-115485 Format CSS #51

wants to merge 2 commits into from

Conversation

izaera
Copy link
Collaborator

@izaera izaera commented Jun 24, 2020 •
edited
Loading

This is a followup of brianchandotcom#90496 to apply the feedback given in this comment from Brian:

modules/apps/frontend-css/frontend-css-variables-web/src/test/resources/com/liferay/frontend/css/variables/web/internal/servlet/taglib/liferay_css_variables_1.html

Can we indent the CSS in the HTML or is the bad formatting on purpose? Please send a follow up pull if we can indent.

@liferay-continuous-integration
Copy link
Collaborator

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@izaera
Copy link
Collaborator Author

izaera commented Jun 24, 2020

ci:test:relevant

@izaera
Copy link
Collaborator Author

izaera commented Jun 24, 2020

ci:test:sf

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 0df14b8ed544d2c0286c4cc200703e3005e673ad

Sender Branch:

Branch Name: LPS-115485
Branch GIT ID: deeeb9f37f78845f07c96be0b97f590eea7af057

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 20 out of 20 jobs passed

✔️ ci:test:relevant - 50 out of 50 jobs passed in 1 hour 43 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 0df14b8ed544d2c0286c4cc200703e3005e673ad

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 1eb935eac6911217dfe48eb2379d11fb23dd7f33

ci:test:stable - 20 out of 20 jobs PASSED
20 Successful Jobs:
ci:test:relevant - 50 out of 50 jobs PASSED
50 Successful Jobs:
For more details click here.

@izaera
Copy link
Collaborator Author

izaera commented Jun 24, 2020

ci:test:sf

@izaera
Copy link
Collaborator Author

izaera commented Jun 24, 2020

ci:test:relevant

@jbalsas jbalsas assigned jbalsas and unassigned izaera Jun 24, 2020
@izaera
Copy link
Collaborator Author

izaera commented Jun 24, 2020

I have rerun the tests. It may be a waste of resources, but having pushed new code it seems the correct thing to do.

What do you think?

@jbalsas
Copy link

jbalsas commented Jun 24, 2020

sealofapproval

Could you maybe expand a little the part in the description where it says "to apply the feedback given in this comment."... so we might not need to navigate there? 😘

@jbalsas
Copy link

jbalsas commented Jun 24, 2020

I have rerun the tests. It may be a waste of resources, but having pushed new code it seems the correct thing to do.

fofree

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 0df14b8ed544d2c0286c4cc200703e3005e673ad

Sender Branch:

Branch Name: LPS-115485
Branch GIT ID: b64e52370de0191453f68e46c59ef09c9b249cbd

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 20 out of 20 jobs passed

✔️ ci:test:relevant - 50 out of 50 jobs passed in 1 hour 34 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 0df14b8ed544d2c0286c4cc200703e3005e673ad

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 1eb935eac6911217dfe48eb2379d11fb23dd7f33

ci:test:stable - 20 out of 20 jobs PASSED
20 Successful Jobs:
ci:test:relevant - 50 out of 50 jobs PASSED
50 Successful Jobs:
For more details click here.

@jbalsas
Copy link

jbalsas commented Jun 24, 2020

ci:forward

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

  •     ci:test:relevant
  •     ci:test:sf
  •     ci:test:stable

@liferay-continuous-integration
Copy link
Collaborator

Skipping previously passed test suites:
ci:test:relevant
ci:test:sf

@liferay-continuous-integration
Copy link
Collaborator

All required test suite(s) passed.
Forwarding pullrequest to brianchandotcom.

Closed
@liferay-continuous-integration
Copy link
Collaborator

Pull request has been successfully forwarded to brianchandotcom#90587

brianchandotcom pushed a commit to brianchandotcom/liferay-portal that referenced this pull request Jun 24, 2020
@izaera @brianchandotcom
LPS-115485 Add test case with quoted value
a31d306 
As suggested in liferay-frontend#51 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wincent wincent wincent left review comments

@jbalsas jbalsas jbalsas left review comments

Assignees

@jbalsas jbalsas

Labels
ci:test:relevant - success ci:test:sf - success ci:test:stable - success
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@izaera @liferay-continuous-integration @jbalsas @wincent