Fixed getFee() for binance exchange (askmike#2578)

* * fixed getFee() for binance
bugron · Oct 20, 2018 · 1a5f4ae · 1a5f4ae
1 parent aa4f4d8
commit 1a5f4ae
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 6 deletions.
diff --git a/core/pipeline.js b/core/pipeline.js
@@ -6,7 +6,7 @@
   all enabled plugins are actually supported by that market.
 
   Read more here:
-  https://gekko.wizbit/docs/internals/architecture.html
+  https://gekko.wizb.it/docs/internals/architecture.html
 
 */
 

diff --git a/docs/extending/add_an_exchange.md b/docs/extending/add_an_exchange.md
@@ -48,7 +48,7 @@ The callback needs to have the parameters of `err` and `ticker`. Ticker needs to
 
     this.exchange.getFee(callback)
 
-The callback needs to have the parameters of `err` and `fee`. Fee is a float that represents the amount the exchange takes out of the orders Gekko places. If an exchange has a fee of 0.2% this should be `0.0002`.
+The callback needs to have the parameters of `err` and `fee`. Fee is a float that represents the amount the exchange takes out of the orders Gekko places. If an exchange has a fee of 0.2% this should be `0.002`.
 
 ### getPortfolio
 

diff --git a/exchange/wrappers/binance.js b/exchange/wrappers/binance.js
@@ -63,7 +63,7 @@ const Trader = function(config) {
     // Though we can deduce feePercent based
     // on user fee tracked through `this.getFee`.
     // Set default here, overwrite in getFee.
-    this.fee = 0.1;
+    this.fee = 0.001;
     // Set the proper fee asap.
     this.getFee(_.noop);
 
@@ -212,13 +212,22 @@ Trader.prototype.getFee = function(callback) {
     if(err)  {
       return callback(err);
     }
-
     const basepoints = data.makerCommission;
 
+    /** Binance raw response
+    { makerCommission: 10,
+      takerCommission: 10,
+      buyerCommission: 0,
+      sellerCommission: 0,
+      canTrade: true,
+      canWithdraw: true,
+      canDeposit: true,
+      So to get decimal representation of fee we actually need to divide by 10000
+    */
     // note non standard func, see constructor
-    this.fee = basepoints / 100;
+    this.fee = basepoints / 10000;
 
-    callback(undefined, basepoints / 100);
+    callback(undefined, this.fee);
   }
 
   const fetch = cb => this.binance.account({}, this.handleResponse('getFee', cb));

diff --git a/web/routes/baseConfig.js b/web/routes/baseConfig.js
@@ -77,6 +77,11 @@ config.mongodb = {
   }]
 }
 
+config.adviceWriter = {
+  enabled: false,
+  muteSoft: true,
+}
+
 // ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 //                       CONFIGURING BACKTESTING
 // ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~