Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MQTTv5 support in rumqttd #621

Open
10 of 19 tasks
swanandx opened this issue May 18, 2023 · 3 comments
Open
10 of 19 tasks

MQTTv5 support in rumqttd #621

swanandx opened this issue May 18, 2023 · 3 comments
Assignees
Labels
broker Related to rumqttd

Comments

@swanandx
Copy link
Member

swanandx commented May 18, 2023

This issue is for tracking the progress of MQTTv5 support in our broker ( rumqttd ) 🚀

We encourage everyone to try out MQTTv5 and help us with your valuable feedback & contributions. Feel free to comment below <3


Features

Done

WIP / Under Review

TODO

  • Reason code and string on ACKs
  • Enhanced Auth

Supported, but not in use

  • Server reference / redirect
  • Server Keep Alive
  • Optional Server feature availability
  • User Properties

NOTE: Features having partial support aren't marked as Done, like server disconnect etc. e.g. we have ability to send Disconnect packets, but we aren't sending them everywhere yet.
Support for some features can be very subjective, e.g. User Properties or Enhanced Auth.

@swanandx swanandx pinned this issue May 18, 2023
@swanandx swanandx self-assigned this May 18, 2023
@swanandx swanandx added the broker Related to rumqttd label May 18, 2023
@stale stale bot added the stale Not moving forward; blocked label Jun 21, 2023
@stale stale bot removed the stale Not moving forward; blocked label Jul 30, 2023
@tmbull
Copy link

tmbull commented Oct 5, 2023

Hi @swanandx . I was wondering if there was any blocker (other than the maintainers' time) to merging these features in? I am interested in using rumqttd, primarily due to the embeddable nature of the service, but I have clients that are already leveraging MQTT5 features.

@swanandx
Copy link
Member Author

swanandx commented Oct 5, 2023

Hey @tmbull, as you mentioned already, maintainers' time is the blocker, and I think getting those PRs reviewed before merging would be better, but if its urgent, we can try to figure out some workaround like merging without review ( though I don't support it much 🤣 ) or prioritize reviews.

Can you please let me know specifically which MQTTv5 features are required by those clients, so those can be prioritized?

Thank you for your interest 💯

@tmbull
Copy link

tmbull commented Oct 6, 2023

Thanks for the quick reply! Shared subscriptions are the big feature for me, which you already have merged in. Session expiry and max packet size would be nice to have, but it is not an urgent matter so please take your time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
broker Related to rumqttd
Projects
None yet
Development

No branches or pull requests

2 participants