Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rumqttd): assign random client identifier to clients #709

Merged
merged 14 commits into from
Feb 21, 2024

Conversation

swanandx
Copy link
Member

@swanandx swanandx commented Sep 6, 2023

In case client tries to connect with client identifier of 0 length, i.e. empty client id, rumqttd assigns it a random client ID to use.

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • Formatted with cargo fmt
  • Make an entry to CHANGELOG.md if it's relevant to the users of the library. If it's not relevant mention why.

rumqttd/src/server/broker.rs Outdated Show resolved Hide resolved
rumqttd/src/link/remote.rs Show resolved Hide resolved
rumqttd/src/protocol/v4/connack.rs Show resolved Hide resolved
@swanandx swanandx mentioned this pull request Sep 7, 2023
19 tasks
@swanandx swanandx requested a review from h3nill February 16, 2024 09:10
@swanandx swanandx changed the title Assign random client identifier to clients feat(rumqttd): assign random client identifier to clients Feb 20, 2024
rumqttd/src/link/remote.rs Show resolved Hide resolved
rumqttd/src/link/remote.rs Show resolved Hide resolved
rumqttd/src/link/remote.rs Show resolved Hide resolved
@swanandx swanandx merged commit 70d0cf9 into main Feb 21, 2024
3 of 4 checks passed
@swanandx swanandx deleted the assign-client-id branch February 21, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants