Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Will messages and will delay interval #686

Merged
merged 9 commits into from
Sep 2, 2023
Merged

Will messages and will delay interval #686

merged 9 commits into from
Sep 2, 2023

Conversation

swanandx
Copy link
Member

@swanandx swanandx commented Aug 20, 2023

Bring back support for will messages and also support will delays.

We separate disconnection and publishing will messages. Will messages are published after disconnection ( and cleanup ).

Type of change

New feature (non-breaking change which adds functionality)

NOTE: This can be considered breaking as signature of some fns in rumqttd are changed. In reality, this shouldn't affect any of the user, but still.

Checklist:

  • Formatted with cargo fmt
  • Make an entry to CHANGELOG.md if its relevant of user of the library. If its not relevant mention why.

@swanandx swanandx mentioned this pull request Aug 20, 2023
19 tasks
Copy link

@h3nill h3nill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apart from downside of tasks now being kept running longer as we discussed, lgtm.

@swanandx swanandx merged commit 6b8bcdb into main Sep 2, 2023
3 checks passed
@swanandx swanandx deleted the will-and-will-delay branch September 2, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants