Remove SubAck/UnsubAck/PubAck/PubRec/PubRel/PubComp reason code errors from critical state error

[xiaocq2001]

Type of change

Bug fix (non-breaking change which fixes an issue): #875
In v5, filtered error cases so ACK fail cases are not disconnecting.

Checklist:

• Formatted with cargo fmt
• Make an entry to CHANGELOG.md if it's relevant to the users of the library. If it's not relevant mention why.

[coveralls]

Pull Request Test Coverage Report for Build 9475994142

Details

• 0 of 4 (0.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall first build on chxiao/disconnect_by_case at 36.129%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
rumqttc/src/v5/eventloop.rs	0	4	0.0%

Totals
Change from base Build 9451919087:	36.1%
Covered Lines:	5970
Relevant Lines:	16524

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 9641321877

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 0 of 12 (0.0%) changed or added relevant lines in 2 files are covered.
• No unchanged relevant lines lost coverage.
• Overall first build on chxiao/disconnect_by_case at 36.127%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
rumqttc/src/v5/eventloop.rs	0	2	0.0%
rumqttc/src/v5/state.rs	0	10	0.0%

Totals
Change from base Build 9451919087:	36.1%
Covered Lines:	5970
Relevant Lines:	16525

---

💛 - Coveralls

[swanandx]

LGTM! just some minor changes.

PS: I don't think logging warn! is correct in case of failure reason code ( because i think it is upto application to determine how to treat reason code ). But let's keep it for now for smooth transition from returning error to logging warning. Can you also add this under changed section of changelog that we will be logging warnings?

Thanks for the PR!

[xiaocq2001]

Updated, please check.

[coveralls]

Pull Request Test Coverage Report for Build 9672557916

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 0 of 10 (0.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall first build on chxiao/disconnect_by_case at 36.138%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
rumqttc/src/v5/state.rs	0	10	0.0%

Totals
Change from base Build 9451919087:	36.1%
Covered Lines:	5970
Relevant Lines:	16520

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 9672609567

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 0 of 10 (0.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall first build on chxiao/disconnect_by_case at 36.138%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
rumqttc/src/v5/state.rs	0	10	0.0%

Totals
Change from base Build 9451919087:	36.1%
Covered Lines:	5970
Relevant Lines:	16520

---

💛 - Coveralls

[swanandx]

Thank you so much for your patience and contribution!