Remove SubAck/UnsubAck/PubAck/PubRec/PubRel/PubComp reason code errors from critical state error

rumqttc/CHANGELOG.md

@@ -35,6 +35,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 * Ordering of `State.events` related to `QoS > 0` publishes
 * Filter PUBACK in pending save requests to fix unexpected PUBACK sent to reconnected broker.
 * Resume session only if broker sends `CONNACK` with `session_present == 1`.
+* No disconnection on v5 PubAck/PubRec/PubRel/PubComp/Sub/Unsub failures.
 
 ### Security
 

rumqttc/src/v5/eventloop.rs

@@ -168,7 +168,19 @@ impl EventLoop {
             Err(e) => {
                 // MQTT requires that packets pending acknowledgement should be republished on session resume.
                 // Move pending messages from state to eventloop.
-                self.clean();
+                // The PubAckFail/PubRecFail/PubRelFail/PubCompFail/SubFail/UnsubFail errors are not critical errors.
+                match e {
+                    ConnectionError::MqttState(StateError::PubAckFail { .. })
+                    | ConnectionError::MqttState(StateError::PubRecFail { .. })
+                    | ConnectionError::MqttState(StateError::PubRelFail { .. })
+                    | ConnectionError::MqttState(StateError::PubCompFail { .. })
+                    | ConnectionError::MqttState(StateError::SubFail { .. })
+                    | ConnectionError::MqttState(StateError::UnsubFail { .. }) => {}
+                    _ => {
+                        warn!("Disconnect due to a critical error: {:?}", e);
+                        self.clean()
+                    }
+                };
                 Err(e)
             }
         }