Disable default docker config provider #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI: There appears to be some incompatible changes made upstream (kubernetes) to auth providers. Not sure when / if those changes will eventually land on the fork we are using... Specifically... amazon-ecr is always enabled: https://github.com/kubernetes/kubernetes/blob/master/pkg/credentialprovider/aws/aws_credentials.go#L77-L80 And will return an empty dockerconfig if it is 'disabled': https://github.com/kubernetes/kubernetes/blob/master/pkg/credentialprovider/aws/aws_credentials.go#L173 This change will require changes on imgpkg, since we will treat that case as 'we found a cred for your image... try using an empty username / password' |
cppforlife
reviewed
Sep 22, 2021
cppforlife
reviewed
Sep 22, 2021
- This interferes with the ordering of auth imgpkg uses. -- Specifically, it will prefer the docker config.json file over the auth cli flags. - There doesn't seem to be a nice way to configure / turn this provider off. Patching the vendor directory. Will try to make the change upstream. Authored-by: Dennis Leon <leonde@vmware.com>
Authored-by: Dennis Leon <leonde@vmware.com>
DennisDenuto
force-pushed
the
disable-defaultDockerConfigProvider
branch
from
657abd0
to
e8ca6f5
Compare
joaopapereira
added a commit
to carvel-dev/vendir
that referenced
this pull request
Aug 22, 2022
Due to the inclusion of imgpkg as a library we need to ensure that the change made in carvel-dev/imgpkg#255 stays in effect. This will behavior can be removed when we complete the issue carvel-dev/imgpkg#397 Signed-off-by: Joao Pereira <joaod@vmware.com>
joaopapereira
added a commit
to carvel-dev/vendir
that referenced
this pull request
Aug 22, 2022
Due to the inclusion of imgpkg as a library we need to ensure that the change made in carvel-dev/imgpkg#255 stays in effect. This will behavior can be removed when we complete the issue carvel-dev/imgpkg#397 Signed-off-by: Joao Pereira <joaod@vmware.com>
joaopapereira
added a commit
to carvel-dev/vendir
that referenced
this pull request
Aug 22, 2022
Due to the inclusion of imgpkg as a library we need to ensure that the change made in carvel-dev/imgpkg#255 stays in effect. This will behavior can be removed when we complete the issue carvel-dev/imgpkg#397 Signed-off-by: Joao Pereira <joaod@vmware.com>
joaopapereira
added a commit
to carvel-dev/vendir
that referenced
this pull request
Aug 23, 2022
Due to the inclusion of imgpkg as a library we need to ensure that the change made in carvel-dev/imgpkg#255 stays in effect. This will behavior can be removed when we complete the issue carvel-dev/imgpkg#397 Signed-off-by: Joao Pereira <joaod@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
- [ ] Submit an issue/PR upstream to allow disabling the default docker provider. Extend this change: kubernetes/kubernetes@a947c32#diff-0ebbc5bb19e182a89f5992c919d5fe2254af767f4611835010367b324b271df9R51-R53