Using imgpkg as a library causes docker authentication failure

[joaopapereira]

What steps did you take:
When using imgpkg as a library when trying to push images to the registry, imgpkg always tries to get the credentials from the docker-credential helper as if it was in an IAAS, causing, in some cases, the authentication to fail and get 401.

Users do not know that the following patch needs to be applied https://github.com/vmware-tanzu/carvel-imgpkg/blob/develop/hack/patch-k8s-pkg-credentialprovider.patch on their vendor directory

What happened:
If the users do not apply the patch that imgpkg is also using on the dependency their application will get a 401.

What did you expect:
Remove the need to patch this dependency, but incorporate the needed code as part of imgpkg or use a different credential provider that does not force us to do this patch in the vendor folder.

Anything else you would like to add:
The bare minimum that we can do is to add some information about this in the docs. Not the optimal solution.

Environment:

• imgpkg version (use imgpkg --version): version higher than 0.19
• Docker registry used (e.g. Docker HUB): All
• OS (e.g. from /etc/os-release): All

---

Vote on this request

This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.

👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"

We are also happy to receive and review Pull Requests if you want to help work on this issue.

[joaopapereira]

Fixed by PR #431 and released in version 0.32.0