Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplify isHtml regex #1699

Closed
wants to merge 3 commits into from
Closed

simplify isHtml regex #1699

wants to merge 3 commits into from

Conversation

5saviahv
Copy link
Contributor

  • removed #id part from regex
  • html may begin with whitespace, but can not start with some arbitrary characters so string like html: <p>bar<p>foo will fail, but <p>bar<p>foo will pass.
  • since second regex case can't happen we can simplify test in function
  • removed JSDoc comment from quickExpr, since it is not really accessible.

@5saviahv 5saviahv changed the title simplify ishtml regex simplify isHtml regex Jan 25, 2021
@5saviahv 5saviahv closed this Feb 3, 2021
@5saviahv 5saviahv deleted the isHtml branch February 3, 2021 07:44
fb55 added a commit that referenced this pull request Feb 4, 2021
@fb55 @5saviahv
refactor(utils): Simplify quickExpr
6cd7ff4 
Now allows a `#` before the string.

BREAKING: Now requires a letter directly after the `<`. Both parsers would have parsed this as text before.

Reivival of #1699

Co-Authored-By: 5saviahv <49443574+5saviahv@users.noreply.github.com>
@fb55 fb55 mentioned this pull request Feb 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@5saviahv