Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(utils): Simplify quickExpr #1716

Merged
merged 1 commit into from
Feb 4, 2021
Merged

refactor(utils): Simplify quickExpr #1716

merged 1 commit into from
Feb 4, 2021

Conversation

fb55
Copy link
Member

@fb55 fb55 commented Feb 4, 2021

Now allows a # before the string.

BREAKING: Now requires a letter directly after the <. Both parsers would have parsed this as text before.

@5saviahv #1699 was a great find, thanks for opening it! I wasn't sure about the actual implementation, here is my take; with it, we still allow text around the actual string, but ban things that definitely aren't tags (see breaking).

Now allows a `#` before the string.

BREAKING: Now requires a letter directly after the `<`. Both parsers would have parsed this as text before.

Reivival of #1699

Co-Authored-By: 5saviahv <49443574+5saviahv@users.noreply.github.com>
@5saviahv
Copy link
Contributor

5saviahv commented Feb 4, 2021

I see whats your aim is, and since it acts only for testing, it should be fine.

@fb55 fb55 merged commit 4aa3d39 into main Feb 4, 2021
@fb55 fb55 deleted the refactor/quick-expr branch February 4, 2021 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants