Remove constructor-less struct-initialization with initializer lists,…

… which

doesn't work yet in C++11. As a result, we're now fully compatible with C++11.

PiperOrigin-RevId: 293195058

BUILD

@@ -1,8 +1,8 @@
 # Toplevel build-file for Verible libraries and tools.
 # To compile the tools, invoke
-#  bazel build --cxxopt='-std=c++17' ...
+#  bazel build ...
 # Run tests with
-#  bazel test --cxxopt='-std=c++17' ...
+#  bazel test ...
 
 licenses(["notice"])  # Apache 2.0
 

README.md

@@ -21,12 +21,12 @@ languages.
 
 Verible's code base is written in C++.
 
-To build, you need the [bazel] build system and a C++17 compatible compiler
+To build, you need the [bazel] build system and a C++11 compatible compiler
 (e.g. >= g++-7; Using clang currently fails to compile the m4 dependency).
 
 ```bash
 # Build all tools and libraries
-bazel build --cxxopt='-std=c++17' //...
+bazel build //...
 ```
 
 ### Test
@@ -35,7 +35,7 @@ To run the tests in [bazel]:
 
 ```bash
 # Run all tests
-bazel test --cxxopt='-std=c++17' //...
+bazel test //...
 ```
 
 You can access the generated artifacts under `bazel-bin/`. For instance the

common/text/macro_definition.h

@@ -46,11 +46,15 @@ struct DefaultTokenInfo : public TokenInfo {
 
 // Macro formal parameter specification: name with optional default.
 struct MacroParameterInfo {
+  MacroParameterInfo(const TokenInfo& n = TokenInfo::EOFToken(),
+                     const TokenInfo& d = TokenInfo::EOFToken())
+      : name(n), default_value(d) {}
+
   // Name of macro parameter.
-  TokenInfo name = TokenInfo::EOFToken();
+  TokenInfo name;
 
   // Macro parameters may have default values.  [Verilog]
-  TokenInfo default_value = TokenInfo::EOFToken();
+  TokenInfo default_value;
 
   bool HasDefaultText() const { return !default_value.text.empty(); }
 };

common/util/vector_tree.h

@@ -698,6 +698,8 @@ std::ostream& operator<<(std::ostream& stream, const VectorTree<T>& node) {
 // traversal.
 template <typename LT, typename RT>
 struct VectorTreeNodePair {
+  VectorTreeNodePair() {}
+  VectorTreeNodePair(const LT* l, const RT* r) : left(l), right(r) {}
   const LT* left = nullptr;
   const RT* right = nullptr;
 };

verilog/formatting/token_annotator_test.cc

@@ -58,6 +58,9 @@ namespace {
 // We do not want to compare break penalties, because that would be too
 // change-detector-y.
 struct ExpectedInterTokenInfo {
+  constexpr ExpectedInterTokenInfo(int spaces, const SpacingOptions& bd)
+      : spaces_required(spaces), break_decision(bd) {}
+
   int spaces_required = 0;
   SpacingOptions break_decision = SpacingOptions::Undecided;