googletest library: download hash not matching anymore. #1168
Labels
build system
matters pertaining to building Verible
Comments
hzeller
changed the title
|
Recursive diff ( EDIT: |
|
Thanks for the investigation, Mariusz! |
hzeller
added a commit
to hzeller/verible
that referenced
this issue
Feb 1, 2022
The sha256sum hash of https://github.com/google/googletest/archive/refs/tags/release-1.11.0.zip Changed from 353571c2440176ded91c2de6d6cd88ddd41401d14692ec1f99e35d013feda55a old/release-1.11.0.zip 63afcb1690b2139b2d9c7ad1df3de87697530fb1fd6869622cff26c77a3b0cfb new/release-1.11.0.zip Investigation by @mglb revealed that there is no change in content for any file inside the archive, just timestamps changed. Now why that was happening is a different question, but the change is benign so ok to update our expectation of the hash. Fixes chipsalliance#1168 Signed-off-by: Henner Zeller <h.zeller@acm.org>
hzeller
added a commit
to hzeller/verible
that referenced
this issue
Feb 1, 2022
Context: Due to some glitch, the content hash of the googletest zip changed (see chipsalliance#1168). It looks like the cause was rolled back... https://twitter.com/tgummerer/status/1488493440103030787 But now our CI caches are discombobulated. Change their names to force a fresh re-build. Signed-off-by: Henner Zeller <h.zeller@acm.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The googletest release mentioned in the WORKSPACE just changed the content:
https://github.com/google/googletest/archive/refs/tags/release-1.11.0.zip
This used to have sha256sum of
353571c2440176ded91c2de6d6cd88ddd41401d14692ec1f99e35d013feda55a, now it is63afcb1690b2139b2d9c7ad1df3de87697530fb1fd6869622cff26c77a3b0cfb.This could be benign (e.g. github was changing their zip library and repackaged things), but is worth investigating first before changing our expected hash.
The text was updated successfully, but these errors were encountered: