Skip to content
This repository has been archived by the owner on May 12, 2024. It is now read-only.

fix #80 #81

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix #80 #81

wants to merge 3 commits into from

Conversation

huang12zheng
Copy link

No description provided.

@chipsenkbeil
Copy link
Owner

@huang12zheng I think the new version of async-graphql needs a newer version of Rust to support cargo for the 2021 edition. The minimum version of 1.49.0 is quite old, so I'm fine with us bumping up the version to something much newer.

Separately, for the nightly tests, the compilation error checks are failing, but skimming through them I think you can just run the tests with TRYBUILD=overwrite since it's just the wording that changed a little bit.

Other than those two adjustments, there was something minor with clippy that needs to be fixed up.

@chipsenkbeil
Copy link
Owner

chipsenkbeil commented Oct 11, 2022

Sorry, when I said run tests with TRYBUILD=overwrite, I meant run them manually with that environment variable set. It will overwrite some files that we can check into your PR.

We don't want to always set it as that will cause our macro ui tests to always overwrite, which can cause real failures to get hidden.

Check out trybuild for more info on those tests: https://github.com/dtolnay/trybuild

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants