Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional properties to Sources Tab in Settings screen #425

Closed
gep13 opened this issue Mar 10, 2017 · 10 comments
Closed

Add additional properties to Sources Tab in Settings screen #425

gep13 opened this issue Mar 10, 2017 · 10 comments
Assignees
@gep13
Labels
Improvement Issues that enhances existing functionality, or adds new features
Milestone
0.15.0

Comments

@gep13
Copy link
Member

gep13 commented Mar 10, 2017

Specifically:

  • By Pass Proxy
  • Self Service

/cc @ferventcoder
@gep13 gep13 added the Improvement Issues that enhances existing functionality, or adds new features label Mar 10, 2017
@gep13 gep13 added this to the 0.15.0 milestone Mar 10, 2017
@gep13 gep13 self-assigned this Mar 10, 2017
gep13 added a commit that referenced this issue Mar 10, 2017
@gep13
(GH-425) Initial work on new properties
0caec90 
- Added necessary UI elements
- Updated model classes with new properties
- Need to wait on updated Chocolatey Lib in order to fully test
@gep13
Copy link
Member Author

gep13 commented Mar 10, 2017

This is how the screen has been made to look:

image

Thoughts?

@ferventcoder
Copy link
Member

I think that looks great! A small change though to the checkbox labels - I'm not sure they need "Is State". I would prefer either "State" or "State?"

  • Disabled?
  • Bypass Proxy?
  • Self-Service Allowed? Note: Business Edition Required

@gep13
Copy link
Member Author

gep13 commented Mar 11, 2017

@ferventcoder yip, I can fix that up.

Self-Service Allowed? Note: Business Edition Required

That is a lot of text to put in. Would you be ok with the latter part going into a tooltip? And for it to be disabled if not in business edition?

@ferventcoder
Copy link
Member

Tooltip. They can still set it, but let's put in a tool tip over both the text and the checkbox itself.

@RichiCoder1
Copy link
Contributor

RichiCoder1 commented Mar 11, 2017 •
edited
Loading

@gep13 @ferventcoder It might not be a terrible idea to figure out a tooltip or ❔ helper, if only to provide either an explainer or link to docs for some of these properties. Currently you have to have some knowledge of sources to understand these properties. Or to run choco source --help, which defeats the purpose of the GUI 😛

@ferventcoder
Copy link
Member

Even better - having a help menu that pulls up, running choco source --help and converting the markdown in the same way we do when converting the output for the docs part of the wiki/website.

And yes, tooltips are awesome as well. Thinking out loud, link up the name to the option on CLI and parse the description out of the CLI return.

@RichiCoder1
Copy link
Contributor

We don't technically have access to CLI output after the rewrite ;). But I do believe that we can pull the description info though lib. Will have to look...

@ferventcoder
Copy link
Member

The info is available in each command. :)

ferventcoder pushed a commit to ferventcoder/ChocolateyGUI that referenced this issue Jun 12, 2017
@gep13 @ferventcoder
(chocolateyGH-425) New source settings
2e5a7ce 
- Added necessary UI elements
- Updated model classes with new properties
RichiCoder1 pushed a commit that referenced this issue Jun 22, 2017
@gep13 @RichiCoder1
(GH-425) Initial work on new properties
4574655 
- Added necessary UI elements
- Updated model classes with new properties
- Need to wait on updated Chocolatey Lib in order to fully test
ferventcoder pushed a commit to ferventcoder/ChocolateyGUI that referenced this issue Jun 26, 2017
@gep13 @ferventcoder
(chocolateyGH-425) New source settings
1f73e6f 
- Added necessary UI elements
- Updated model classes with new properties
mwallner pushed a commit that referenced this issue Jun 29, 2017
@ferventcoder @mwallner
(GH-371) Enable self-service mode (#451)
5f350d1 
* (GH-371) Enable self-service mode

When using self-service installs, a feature in Chocolatey for Business,
it provides a background agent that actually performs the
installations. Chocolatey itself handles passing through the proper
information to the background service so that installations can occur.
The GUI should notice the feature is switched on and adjust to allow
non-administrators to run certain commands in the GUI without
attempting to elevate.

Original commit from @RichiCoder1.

* (maint) capture connection closed error

There are errors where a connection was closed during an operation,
like when the application is being closed when running a query. Capture
those and allow the application to exit peacefully.

Original commit from @RichiCoder1.

* (maint) Add Pin for German resources

* (GH-425) New source settings

- Added necessary UI elements
- Updated model classes with new properties

* (GH-371) Ensure config is properly set

When calling into chocolatey.lib, if the Container is accessed
prior to having the configuration all set, any additonal components
that Chocolatey attempts to register will be ignored. This causes
issues with using Chocolatey and registering licensed configuration
and components. Ensure that Chocolatey does get set appropriately
by making a call to do that early in the process load.

* (maint) upgrade to Chocolatey 0.10.7

* Ensure we don't elevate when operating through a background agent.
@RichiCoder1
Copy link
Contributor

This is good now, right?

@mwallner
Copy link
Member

LGTM, altough we've got a little alignment issue with the German (long) texts ...
-> will handle in follow-up issue
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gep13 gep13

Labels
Improvement Issues that enhances existing functionality, or adds new features
Projects
None yet
Milestone
0.15.0
Development

No branches or pull requests
4 participants
@ferventcoder @gep13 @RichiCoder1 @mwallner