(GH-371) Enable self-service mode #451
Conversation
ferventcoder
added
the
Feature
ferventcoder
force-pushed
the
feature/GH-371_BackgroundMode_v3
branch
from
a12418c
to
d644fd4
Compare
|
There is still something not quite right here:
Then the connection between the GUI and the subprocess is super erratic. Is this a known issue? |
|
I think I found an issue with the background service that didn't bubble up to the GUI at all. "[Fatal] Calls to Chocolatey only are allowed. Attempted call to 'C:\vagrant\resources\ChocolateyGiu\Subprocess\ChocolateyGui.Subprocess.exe'. This has been logged for an administrator to review." |
|
But that means progress! |
|
I'm guessing the fatal error kills the GUI Subprocess. |
|
Still getting issues with connections and this as well:
|
|
Looking at the logs it appears things are working appropriately, but something causes it to kill after about 2-3 seconds. Running it with straight choco and it completes successfully. I wonder if it is because GUI uses |
|
No, it looks like the agent returns a message that makes the GUI think it is complete. |
|
@RichiCoder1 @gep13 appveyor issues don't seem related - it's a cake error. |
|
Looks like it's just a StyleCop error: That run issue is a Xaml issue (that I could have sworn we already fixed.) |
|
|
|
@RichiCoder1 I think we can merge this into develop - will create another intermediate build and do some testing - is that ok with you? |
|
As long as all of the xaml is good to go, I'm happy with that - we'll change this from closes though. |
|
I suppose most all the remaining work is in Choco.Lib and the integration layer and those can be fixed in future PRs. |
|
There is still some work here to be completed - like the issue with something shutting down the self-service before it completes the install And ensuring those values do get set in source options. |
|
@ferventcoder Could you elaborate? I'm not sure I follow. |
|
Good heavens above, rebasing can go die in a fire. |
|
Let me just say the rebase was especially painful the last time I did it |
|
Source options like skip proxy and allow self-service are not actually saved, so I may have missed a setting somewhere. It looks like they are set, but then they are not. |
|
And the self-service aspect still does not actually work for a non-admin - it dies when attempting to do the install. Not sure what causes it just yet. |
|
A couple of additional clean up items on this side, but this will work perfectly once the following are released:
I will add those additional items here today. |
When using self-service installs, a feature in Chocolatey for Business, it provides a background agent that actually performs the installations. Chocolatey itself handles passing through the proper information to the background service so that installations can occur. The GUI should notice the feature is switched on and adjust to allow non-administrators to run certain commands in the GUI without attempting to elevate. Original commit from @RichiCoder1.
There are errors where a connection was closed during an operation, like when the application is being closed when running a query. Capture those and allow the application to exit peacefully. Original commit from @RichiCoder1.
- Added necessary UI elements - Updated model classes with new properties
When calling into chocolatey.lib, if the Container is accessed prior to having the configuration all set, any additonal components that Chocolatey attempts to register will be ignored. This causes issues with using Chocolatey and registering licensed configuration and components. Ensure that Chocolatey does get set appropriately by making a call to do that early in the process load.
ferventcoder
force-pushed
the
feature/GH-371_BackgroundMode_v3
branch
from
d644fd4
to
24a6192
Compare
|
bump @RichiCoder1 :-) |
|
I believe @ferventcoder was just wrapping up the fixes for this. |
|
Was there something left for me here? |
|
I know that there was an issue with saving the self-service and bypass proxy settings, but I wasn't sure what I missed. |
|
I suppose the todo items (deploy fixed version of agent and extension) are technically independent of this PR. Have we confirmed that it works w/ agent now? |
|
Once we merge, I'll do follow up PRs to make sure everything is polished. |
|
I've confirmed it! |
|
if it blows up, you can blame me now :-) |
|
I blame you ;) |
|
This is so much win right here. |
|
well see x_x - I'll hand out this version to a couple of beta-testers tomorrow ;-) |
|
AppVeyor still blows up because of Cake/StyleCop .. will fix tomorrow - TeamCity is fine. |
|
Did you see the only apply background service to non-admins coming in Chocolatey Licensed v1.12? |
|
Ahh, this explains that explosion I saw. |
When using self-service installs, a feature in Chocolatey for Business,
it provides a background agent that actually performs the
installations. Chocolatey itself handles passing through the proper
information to the background service so that installations can occur.
The GUI should notice the feature is switched on and adjust to allow
non-administrators to run certain commands in the GUI without
attempting to elevate.
Supersedes #382
Closes #371