Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove admin only sources/repos #603

Closed
gep13 opened this issue Jun 18, 2018 · 3 comments
Closed

Remove admin only sources/repos #603

gep13 opened this issue Jun 18, 2018 · 3 comments
Assignees
@gep13
Labels
Feature Issues that introduce new functionality to the project, instead of updating existing functionality
Milestone
0.17.0

Comments

@gep13
Copy link
Member

gep13 commented Jun 18, 2018

Currently, the available sources/repos are pulled directly from the Chocolatey Configuration file. As a result, functionality that is included in Chocolatey Lib to filter out the available sources, based on other aspects is lost. Rather than reading directly from the configuration file, the sources_list function of the IChocolateyConfigSettingsService should be used.
@gep13 gep13 added the Feature Issues that introduce new functionality to the project, instead of updating existing functionality label Jun 18, 2018
@gep13 gep13 added this to the 0.17.0 milestone Jun 18, 2018
@gep13 gep13 self-assigned this Jun 18, 2018
@gep13
Copy link
Member Author

gep13 commented Jun 18, 2018

No logic will actually be included in Chocolatey GUI to provide this filtering, instead, this will be defered to Chocolatey Lib, where things like whether it is a licensed version of Chocolatey etc will be inspected, and the correct list of sources/repos will be returned.

@gep13
Copy link
Member Author

gep13 commented Jun 18, 2018

Related to #432

gep13 added a commit to gep13/ChocolateyGUI that referenced this issue Jun 18, 2018
@gep13
(chocolateyGH-603) Use source_list method to get sources
9eda25b 
- Rather than reading the configuration file directly
- This means that Chocolatey.Lib will do the work for filtering this sources list if/when required
@gep13 gep13 mentioned this issue Jun 18, 2018
Merged
gep13 added a commit to gep13/ChocolateyGUI that referenced this issue Jun 19, 2018
@gep13
(chocolateyGH-603) Added back in ReadLock
872a37e 
- To ensure that multiple operations don't happen at same time
ferventcoder added a commit that referenced this issue Jun 20, 2018
@ferventcoder
Merge pull request #604 from gep13/feature/GH-603
a620ff9 
(GH-603, GH-607) Use source_list method to get sources
@gep13 gep13 closed this as completed Jun 20, 2018
gep13 added a commit that referenced this issue Apr 22, 2019
@gep13
(GH-603) Fix bug when updating source information
6018806 
When we changed to getting sources directly from Chocolatey.Lib, rather
reading directly from the config file, we introduced a bug.  Other parts
of Chocolatey GUI expect to have all information about a source
available to it, i.e. UserName and Password of an authenticated feed.
However, this information isn't available when using Chocolatey.Lib to
get the sources.  Instead, still read the sources from the config file
as before, but filter this list, based on the sources that are retrieved
from Chocolatey.Lib.  This is a duplication of effort, however, it does
mean that the work of filtering the sources list remains where it needs
to be, i.e. in Chocolatey.Lib.
@choco-bot
Copy link

🎉 This issue has been resolved in version 0.17.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gep13 gep13

Labels
Feature Issues that introduce new functionality to the project, instead of updating existing functionality
Projects
None yet
Milestone
0.17.0
Development

No branches or pull requests
2 participants
@gep13 @choco-bot