Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove multiple uses of SetCustomLogging #607

Closed
gep13 opened this issue Jun 19, 2018 · 1 comment
Closed

Remove multiple uses of SetCustomLogging #607

gep13 opened this issue Jun 19, 2018 · 1 comment
Assignees
@gep13
Labels
Improvement Issues that enhances existing functionality, or adds new features
Milestone
0.17.0

Comments

@gep13
Copy link
Member

gep13 commented Jun 19, 2018

When Chocolatey GUI first started using Chocolatey Lib, it was necessary to call Lets.GetChocolatey for each command execution.

This is no longer the case, and actually, since 0.10.9 of Chocolatey Lib, doing this actually has an adverse affect on how things work. As such, the multiple calls to Lets.GetChocolatey should be removed, in favour of a single instantiation of Lets.GetChocolatey, that is used everywhere that is required.
@gep13 gep13 added the Improvement Issues that enhances existing functionality, or adds new features label Jun 19, 2018
@gep13 gep13 added this to the 0.17.0 milestone Jun 19, 2018
@gep13 gep13 self-assigned this Jun 19, 2018
gep13 added a commit to gep13/ChocolateyGUI that referenced this issue Jun 19, 2018
@gep13
(chocolateyGH-607) Removed multiple calls to Lets.GetChocolatey
1acd84f 
- Instead, use a single instance across the application
- There are still some remaining all that could be removed, but more work is required here
- Need to capture logs from errors for reporting
ferventcoder added a commit that referenced this issue Jun 20, 2018
@ferventcoder
Merge pull request #604 from gep13/feature/GH-603
a620ff9 
(GH-603, GH-607) Use source_list method to get sources
@gep13 gep13 mentioned this issue Jun 20, 2018
Merged
@gep13 gep13 closed this as completed Jun 20, 2018
@choco-bot
Copy link

🎉 This issue has been resolved in version 0.17.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gep13 gep13

Labels
Improvement Issues that enhances existing functionality, or adds new features
Projects
None yet
Milestone
0.17.0
Development

No branches or pull requests
2 participants
@gep13 @choco-bot