Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option to only show packages with updates doesn't work correctly when automated outdated check is enabled #821

Closed
punker76 opened this issue Mar 8, 2021 · 1 comment · Fixed by #822
Closed

Option to only show packages with updates doesn't work correctly when automated outdated check is enabled #821

punker76 opened this issue Mar 8, 2021 · 1 comment · Fixed by #822
Labels
Bug Issues where something has happened which was not expected or intended
Milestone
0.18.0

Comments

@punker76
Copy link
Member

punker76 commented Mar 8, 2021

Just found this issue after merged dark mode PR where I changed the logic for this too. I'll provide a PR to fix this.
@punker76 punker76 added the Bug Issues where something has happened which was not expected or intended label Mar 8, 2021
@punker76 punker76 added this to the 0.18.0 milestone Mar 8, 2021
punker76 added a commit to punker76/ChocolateyGUI that referenced this issue Mar 8, 2021
@punker76
(chocolateyGH-821) Fix logic of IsShowOnlyPackagesWithUpdateEnabled w…
9b2c0c6 
…hen PreventAutomatedOutdatedPackages is not set

The IsShowOnlyPackagesWithUpdateEnabled will be false if the PreventAutomatedOutdatedPackagesCheck is not set. So you will not see any updated packages without forcing the search for it.
@punker76 punker76 mentioned this issue Mar 8, 2021
Merged
@gep13 gep13 closed this as completed in #822 Mar 9, 2021
gep13 added a commit that referenced this issue Mar 9, 2021
@gep13
Merge pull request #822 from punker76/fix/GH-821
7c94a89 
Fix logic of IsShowOnlyPackagesWithUpdateEnabled when PreventAutomatedOutdatedPackages is not set
@gep13 gep13 changed the title IsShowOnlyPackagesWithUpdateEnabled doesn't work correctly when PreventAutomatedOutdatedPackages is true Option to only show packages with updates doesn't work correctly when automated outdated check is enabled Mar 9, 2021
gep13 added a commit that referenced this issue Mar 9, 2021
@gep13
Merge branch 'release/0.18.0' into master
3d49015 
* release/0.18.0: (113 commits)
  (GH-821) Fix logic of IsShowOnlyPackagesWithUpdateEnabled when PreventAutomatedOutdatedPackages is not set
  (#820) Split default values for global and user
  (#741) Ensure all settings are included
  (maint) Remove unnecessary whitespace
  (#601) Change default for admin settings access
  (#820) Change default for tile view
  (#757) Allow buttons to be enabled/disabled
  (GH-685) Fix setting IsShowOnlyPackagesWithUpdateEnabled in local view
  (GH-685) Create converters only once
  (GH-685) Improve standard remote view
  (GH-685) Make converters more robust
  (GH-685) Add option to set default for dark mode
  (GH-685) Fix missing theme change in SyncTheme
  (GH-685) Update MahApps package
  (GH-685) Add ThemeMode and own ToggleSwitch with icons for dark and light mode
  (GH-685) Introduce IBundledThemeService
  (GH-685) Add better ScrollBar and ScrollViewer styles
  (GH-685) Improve progress dialog
  (GH-685) Add additional Chocolatey colors and brushes
  (GH-685) Remove obsolete unused styles
  ...
@choco-bot
Copy link

🎉 This issue has been resolved in version 0.18.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Issues where something has happened which was not expected or intended
Projects
None yet
Milestone
0.18.0
2 participants
@punker76 @choco-bot