Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that all features/config can be set via parameters during installation of package #741

Closed
gep13 opened this issue Mar 30, 2020 · 1 comment · Fixed by #750
Closed

Ensure that all features/config can be set via parameters during installation of package #741

gep13 opened this issue Mar 30, 2020 · 1 comment · Fixed by #750
Assignees
@gep13
Labels
Bug Issues where something has happened which was not expected or intended
Milestone
0.18.0

Comments

@gep13
Copy link
Member

gep13 commented Mar 30, 2020

In the 0.17.0 release of Chocolatey GUI, we added the ability to set/configure Chocolatey GUI Features via Package Parameters. These are documented in the nuspec, however, there are some features missing that need to get added in:

  • ShowAdditionalPackageInformation
  • AllowNonAdminAccessToSettings
  • UseKeyboardBindings
  • HidePackageDownloadCount

Also, if this gets merged in, then we will have to add a package parameter for this as well.
@gep13 gep13 added the Bug Issues where something has happened which was not expected or intended label Mar 30, 2020
@gep13 gep13 added this to the 0.18.0 milestone Mar 30, 2020
@gep13 gep13 self-assigned this Mar 30, 2020
mkevenaar added a commit to mkevenaar/ChocolateyGUI that referenced this issue Apr 5, 2020
@mkevenaar
(chocolateyGH-741 chocolateyGH-749) Add missing package parameters
54fe369 
I also switched to an helper.ps1 file for the package parameters to not
go over thet 100 lines guideline.
Also the Package Parameter for UseDelayedSearch will now contain the
correct value.
mkevenaar added a commit to mkevenaar/ChocolateyGUI that referenced this issue Apr 5, 2020
@mkevenaar
(chocolateyGH-741 chocolateyGH-749) Add missing package parameters
6bf3797 
I also switched to an helper.ps1 file for the package parameters to not
go over the 100 lines guideline.
Also the Package Parameter for UseDelayedSearch will now contain the
correct value.
@mkevenaar mkevenaar mentioned this issue Apr 5, 2020
Merged
@gep13 gep13 closed this as completed in #750 Apr 5, 2020
gep13 added a commit that referenced this issue Apr 5, 2020
@gep13
Merge pull request #750 from mkevenaar/feature/GH-741
e7c67fe 
(GH-741 GH-749) Add missing package parameters
@mkevenaar mkevenaar mentioned this issue Apr 7, 2020
Merged
@gep13 gep13 changed the title Ensure that all features/config can be set via Package Parameters Ensure that all features/config can be set via parameters during installation of package Mar 8, 2021
gep13 added a commit that referenced this issue Mar 8, 2021
@gep13
(#741) Ensure all settings are included
71d8462 
This includes documenting the flags, as well as testing that all
settings can be set and unset during installation.
gep13 added a commit that referenced this issue Mar 9, 2021
@gep13
Merge branch 'release/0.18.0' into master
3d49015 
* release/0.18.0: (113 commits)
  (GH-821) Fix logic of IsShowOnlyPackagesWithUpdateEnabled when PreventAutomatedOutdatedPackages is not set
  (#820) Split default values for global and user
  (#741) Ensure all settings are included
  (maint) Remove unnecessary whitespace
  (#601) Change default for admin settings access
  (#820) Change default for tile view
  (#757) Allow buttons to be enabled/disabled
  (GH-685) Fix setting IsShowOnlyPackagesWithUpdateEnabled in local view
  (GH-685) Create converters only once
  (GH-685) Improve standard remote view
  (GH-685) Make converters more robust
  (GH-685) Add option to set default for dark mode
  (GH-685) Fix missing theme change in SyncTheme
  (GH-685) Update MahApps package
  (GH-685) Add ThemeMode and own ToggleSwitch with icons for dark and light mode
  (GH-685) Introduce IBundledThemeService
  (GH-685) Add better ScrollBar and ScrollViewer styles
  (GH-685) Improve progress dialog
  (GH-685) Add additional Chocolatey colors and brushes
  (GH-685) Remove obsolete unused styles
  ...
@choco-bot
Copy link

🎉 This issue has been resolved in version 0.18.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gep13 gep13

Labels
Bug Issues where something has happened which was not expected or intended
Projects
None yet
Milestone
0.18.0
Development

Successfully merging a pull request may close this issue.

(GH-741 GH-749) Add missing package parameters mkevenaar/ChocolateyGUI
2 participants
@gep13 @choco-bot