Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(GH-706) Add a settings to prevent searchs preloading #740

Merged
merged 1 commit into from
Mar 30, 2020

Conversation

iammael
Copy link
Contributor

@iammael iammael commented Mar 29, 2020

Add a toggle in the settings view to prevent a blank search when viewing
the list of available packages.

#706

Add a toggle in the settings view to prevent a blank search when viewing
the list of available packages.
Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gep13 gep13 merged commit ae6296f into chocolatey:develop Mar 30, 2020
@gep13
Copy link
Member

gep13 commented Mar 30, 2020

@iammael thank you very much for this addition! I think we will need a follow up change to provide some information about why no packages are being displayed, and also to add an empty itemtemplate to the ListView as well, but that can be covered in another issue.

@iammael iammael deleted the feature/prevent_preload branch March 31, 2020 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants