-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update MUI secondary color #1437
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Much easier to read the small text. I checked every view that references this color and every part of the app. I have one small request before merge that I could use some feedback on. Thanks for updating! 🙏
moped-editor/src/theme/index.js
Outdated
@@ -26,7 +26,7 @@ const theme = createTheme(adaptV4Theme({ | |||
}, | |||
text: { | |||
primary: "#212121", | |||
secondary: "#848484", | |||
secondary: "#666666", | |||
header: "#848484", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is outside the scope of the issue, but I noticed that we use text.header
in only three places in the app where we have tabs: the Dashboard view, the main app header, and in the project view. For some reason, the app header tabs respect text.header
but the other two do not.
This is making me feel like the header style isn't necessary since it isn't working as expected. What do you think about removing this style and those three places that it is used? All three would then default to the new secondary color that you updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that makes sense. I was considering updating the text.header
value to #666666
along with text.secondary
but I was interpreting your issue pretty literally. I figured it would come up in this review either way, and I like your suggestion of removing the header
override entirely. I can definitely add that to this PR today. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds great - thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks amazing! Thanks for making this improvement. 🙏 🚢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, yay for better accessibility :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Easier on the eyes!
Associated issues
Closes cityofaustin/atd-data-tech#17920
Testing
URL to test:
https://deploy-preview-1437--atd-moped-main.netlify.app/moped/dashboard
Steps to test:
#666666
Ship list