Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MUI secondary color #1437

Merged
merged 3 commits into from
Oct 7, 2024
Merged

Conversation

mateoclarke
Copy link
Contributor

@mateoclarke mateoclarke commented Sep 30, 2024

Associated issues

Closes cityofaustin/atd-data-tech#17920

Screenshot 2024-09-30 at 12 34 52 PM Screenshot 2024-09-30 at 12 35 47 PM

Testing

URL to test:
https://deploy-preview-1437--atd-moped-main.netlify.app/moped/dashboard

Steps to test:

  • Open up a page with secondary text, for example, the welcome text on the dashboard.
  • Confirm it is the updated shade of grey, #666666
Screenshot 2024-09-30 at 6 01 32 PM

Ship list

Copy link
Collaborator

@mddilley mddilley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Much easier to read the small text. I checked every view that references this color and every part of the app. I have one small request before merge that I could use some feedback on. Thanks for updating! 🙏

@@ -26,7 +26,7 @@ const theme = createTheme(adaptV4Theme({
},
text: {
primary: "#212121",
secondary: "#848484",
secondary: "#666666",
header: "#848484",
Copy link
Collaborator

@mddilley mddilley Oct 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is outside the scope of the issue, but I noticed that we use text.header in only three places in the app where we have tabs: the Dashboard view, the main app header, and in the project view. For some reason, the app header tabs respect text.header but the other two do not.

This is making me feel like the header style isn't necessary since it isn't working as expected. What do you think about removing this style and those three places that it is used? All three would then default to the new secondary color that you updated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that makes sense. I was considering updating the text.header value to #666666 along with text.secondary but I was interpreting your issue pretty literally. I figured it would come up in this review either way, and I like your suggestion of removing the header override entirely. I can definitely add that to this PR today. 👍

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds great - thanks!

Copy link
Collaborator

@mddilley mddilley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks amazing! Thanks for making this improvement. 🙏 🚢

Copy link
Contributor

@roseeichelmann roseeichelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, yay for better accessibility :)

Copy link
Member

@chiaberry chiaberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easier on the eyes!

@mateoclarke mateoclarke merged commit 7775589 into main Oct 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update secondary text color to MUI default
4 participants