don't parse url for getServiceURL unless required #22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #21
Turns out the following is not always true:
At least when the protocol isn't
http:
orhttps:
. cfenv expects thisto be true in
getServiceURL()
, when using the replacements argument. Itseems to break for some example mongodb urls, like the one added to the
test in this commit.
Fix for now is that if there aren't any replacement values, then return early
with the currently calculated URL. So it would still break if you passed
one of these not-parsed-correctly URLs and replacements, but the odds of that
seem pretty slim.
Also noticed that
url.format()
must be standardizing URLs to return them witha trailing
/
if there was no other path. So now you don't always get thattrailing
/
. Seems survivable.