updates for version 1.0.4 #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@srl295 did you get a chance to review this? Specifically the PR referenced in the initial comment. |
Closed
|
went ahead and merged this and then published to npm as 1.0.4 |
|
sorry, i did not see this at all until the 'went ahead and merged' :( |
|
after the fact LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@srl295 Should probably be in the habit of having someone review version updates - could you take a look?
Should have also had you look at the PR that makes up the functional change for this version - PR #22 - could you peek at that as well?
I'll update npm after merging this.