Split build() for readability #369
Conversation
| // compile SASS along the way | ||
| { | ||
| debug!("Copying remaining assets"); | ||
| fn parse_files(page_files: &files::Files, |
| let doc_html = doc.render(&globals, &parser, &layouts, &mut layouts_cache) | ||
| .chain_err(|| format!("Failed to render for {:?}", doc.file_path))?; | ||
| files::write_document_file(doc_html, dest.join(doc.file_path))?; | ||
| fn construct_page_files(source: &Path, config: &Config) -> Result<files::Files> { |
There was a problem hiding this comment.
construct_page_files -> find_pages
| trace!("Generating other documents"); | ||
| for mut doc in documents { | ||
| trace!("Generating {}", doc.url_path); | ||
| fn process_included_drafts(config: &Config, |
There was a problem hiding this comment.
Ideally this would be split into find_draft_files and parse_drafts. Not sure how clean that'd be at the moment.
| Ok(()) | ||
| } | ||
|
|
||
| fn sort_documents_by_date(posts: &mut Vec<Document>, config: &Config) -> Result<()> { |
There was a problem hiding this comment.
Since this takes in the config, it seems like this could just skip putting the sort policy in the function name because that will eventually be configurable.
There was a problem hiding this comment.
So, what should I call it, as the code is really doing sorting by date ^^'
There was a problem hiding this comment.
Oh! I misread, I though you wanted me to drop the "sort" word. You were talking "sort policy" ^^'
There was a problem hiding this comment.
I can see how that can be missed and be confusing :)
| Ok(()) | ||
| } | ||
|
|
||
| fn generate_posts(posts: &mut Vec<Document>, |
There was a problem hiding this comment.
It'd be nice to find ways to refactor this so the code can be shared between "other" and "posts".
|
|
||
| let default_front = config.posts.default.clone().set_draft(true); | ||
| fn generate_other_docs(posts: Vec<Document>, |
There was a problem hiding this comment.
Confusingly, I'd call this generate_pages. That is the name (so far) for the default collection.
|
I'll do the renaming tonight :) |
I've split cobalt.rs build() function to make it easier to read