Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename some refactored fct #373

Merged
merged 1 commit into from
Jan 27, 2018

Conversation

Geobert
Copy link
Contributor

@Geobert Geobert commented Jan 27, 2018

Here is the follow up of #369 applying your comments!

@Geobert
Copy link
Contributor Author

Geobert commented Jan 27, 2018

@epage : Changing generate_posts code to call the factorised version generate_doc makes excerpt generation fail.
Doesn't make any sense as I've compare the code, and it's the same. Can it be the cloning?

@Geobert
Copy link
Contributor Author

Geobert commented Jan 27, 2018

yeah, the cloning was not a good idea, this is done while rendering excerpt: https://github.com/cobalt-org/cobalt.rs/blob/master/src/document.rs#L312
hence the error.
Wait for CI and if ok, I'll squashed the commit msg :)

@epage
Copy link
Member

epage commented Jan 27, 2018

Looks good. let me know when its squashed.

@Geobert Geobert force-pushed the rename_some_refactored_fct branch 3 times, most recently from 2f7089b to 73fe2ea Compare January 27, 2018 20:55
@epage epage merged commit de7b6d0 into cobalt-org:master Jan 27, 2018
@Geobert Geobert deleted the rename_some_refactored_fct branch January 27, 2018 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants