Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: election-after-restart failed [skipped] #54246

Closed
cockroach-teamcity opened this issue Sep 11, 2020 · 7 comments
Closed

roachtest: election-after-restart failed [skipped] #54246

cockroach-teamcity opened this issue Sep 11, 2020 · 7 comments
Assignees
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. skipped-test
Milestone

Comments

@cockroach-teamcity
Copy link
Member

(roachtest).election-after-restart failed on release-20.2@09786094a013b45e4d794f9cb02a4256f70b9158:

The test failed on branch=release-20.2, cloud=gce:
test artifacts and logs in: /home/agent/work/.go/src/github.com/cockroachdb/cockroach/artifacts/election-after-restart/run_1
	election.go:95,test_runner.go:754: expected query to succeed in less than 15s, took 19.712360991s

More

Artifacts: /election-after-restart

See this test on roachdash
powered by pkg/cmd/internal/issues

@cockroach-teamcity cockroach-teamcity added branch-release-20.2 C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. labels Sep 11, 2020
@cockroach-teamcity cockroach-teamcity added this to the 20.2 milestone Sep 11, 2020
@cockroach-teamcity
Copy link
Member Author

(roachtest).election-after-restart failed on release-20.2@7ab6963f9c48e61df8f138894f69f056fe1aa8f5:

The test failed on branch=release-20.2, cloud=gce:
test artifacts and logs in: /home/agent/work/.go/src/github.com/cockroachdb/cockroach/artifacts/election-after-restart/run_1
	election.go:95,test_runner.go:754: expected query to succeed in less than 15s, took 22.020802541s

More

Artifacts: /election-after-restart

See this test on roachdash
powered by pkg/cmd/internal/issues

@nvanbenschoten
Copy link
Member

@knz can I assign you to take a look at this?

@cockroach-teamcity
Copy link
Member Author

(roachtest).election-after-restart failed on release-20.2@56c72f47ae31ad3373b69f87250d57fdfee176ce:

The test failed on branch=release-20.2, cloud=gce:
test artifacts and logs in: /home/agent/work/.go/src/github.com/cockroachdb/cockroach/artifacts/election-after-restart/run_1
	election.go:95,test_runner.go:754: expected query to succeed in less than 15s, took 17.534954179s

More

Artifacts: /election-after-restart
Related:

See this test on roachdash
powered by pkg/cmd/internal/issues

@tbg
Copy link
Member

tbg commented Sep 23, 2020

@andreimatei didn't you want to assign yourself?

@irfansharif
Copy link
Contributor

I'm back in office today, taking a look now.

@irfansharif
Copy link
Contributor

This test was unskipped recently (#53689) after being skipped over a year ago (#37507). I'm able to repro it pretty easily on my machine (which runs counter to Rafa's experience in #35047 (comment)?).

I used just the following:

rm -r artifacts; make buildshort; make bin/roachtest; roachprod destroy local;
roachtest run election-after-restart --cockroach ./cockroachshort --local --debug --count=10

Looking through the symptoms they're identical to what was described a year ago in #35047 (comment). Our thinking at the time was to address #21849 to address the lag we're tracking in this failure ("expected query to succeed in less than 15s, took 22.020802541s"). In any case, this is not a release blocker. I'm going to re-skip the test and keep this issue open. It also affects master currently though I don't see any issues filed for it. I'm going to defer investigation here, I have a few other tests to skim through.

irfansharif added a commit to irfansharif/cockroach that referenced this issue Sep 23, 2020
See cockroachdb#54246. It was unskipped recently, but it's still flakey (with the
same symptoms from over a year ago).

Release note: None
irfansharif added a commit to irfansharif/cockroach that referenced this issue Sep 23, 2020
See cockroachdb#54246. It was unskipped recently, but it's still flakey (with the
same symptoms from over a year ago).

Release note: None
@irfansharif irfansharif added branch-master Failures and bugs on the master branch. and removed release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. labels Sep 23, 2020
@irfansharif
Copy link
Contributor

+cc @knz you may be interested in the discussion above as it relates to "crdb post restart behavior". It's not something we can do much about in 20.2 but might finally nudge us to pick up #21849 if we're looking to close out another loose end in the area.

irfansharif added a commit to irfansharif/cockroach that referenced this issue Sep 23, 2020
See cockroachdb#54246. It was unskipped recently, but it's still flakey (with the
same symptoms from over a year ago).

Release note: None
craig bot pushed a commit that referenced this issue Sep 23, 2020
54700: roachtest: (re-)skip flaky election-after-restart test r=irfansharif a=irfansharif

See #54246. It was unskipped recently, but it's still flakey (with the
same symptoms from over a year ago).

Release note: None

Co-authored-by: irfan sharif <irfanmahmoudsharif@gmail.com>
@irfansharif irfansharif removed their assignment Sep 28, 2020
@tbg tbg changed the title roachtest: election-after-restart failed roachtest: election-after-restart failed [skipped] Oct 6, 2020
@tbg tbg self-assigned this May 5, 2021
@craig craig bot closed this as completed in 5197551 Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. skipped-test
Projects
None yet
Development

No branches or pull requests

5 participants