Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtests: re-enable election-after-restart and kv/gracefuldraining/nodes=3 #53689

Merged
merged 1 commit into from
Sep 1, 2020

Conversation

knz
Copy link
Contributor

@knz knz commented Aug 31, 2020

Fixes #35047
Fixes #33501

Note that I dislike the idea to run any roachtest under stressrace in the first place.

Release justification: non-production code changes

Release note: None

@knz knz requested review from tbg and irfansharif August 31, 2020 17:05
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@knz knz changed the title roachtests: re-enable election-after-restart roachtests: re-enable election-after-restart and kv/gracefuldraining/nodes=3 Aug 31, 2020
}

// Skipf skips the test. The formatted message becomes the skip reason.
// This implements the skip.skippableTest interface.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/skippable/Skippable

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

…nodes=3

Release justification: non-production code changes

Release note: None
@knz
Copy link
Contributor Author

knz commented Aug 31, 2020

bors r=irfansharif

@craig
Copy link
Contributor

craig bot commented Aug 31, 2020

This PR was included in a batch that was canceled, it will be automatically retried

@craig
Copy link
Contributor

craig bot commented Sep 1, 2020

Build succeeded:

@craig craig bot merged commit f2056ba into cockroachdb:master Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

roachtest: election-after-restart failed [skipped] roachtest: kv/gracefuldraining/nodes=3 failed [skipped]
3 participants