sql/parser: add missing telemetry for unimplemented features #31635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release note (sql change): Attempts to use `CREATE/DROP SCHEMA` will now be collected as telemetry if statistics reporting is enabled, to gauge demand for user-defined schemas.
|
This change is |
knz
force-pushed
the
20181019-metrics-more
branch
from
94908a6
to
64db58d
Compare
Release note (sql change): Attempts to use `DEFERRABLE` and other constraint deferrability options will now be collected as telemetry if statistics reporting is enabled, to gauge demand for tuning time of constraint checking.
Release note (sql change): Attempts to use `CREATE TABLE (LIKE...)` will now be collected as telemetry if statistics reporting is enabled, to gauge demand for this feature.
Release note (sql change): Attempts to use `CREATE TABLE ... WITH` will now be collected as telemetry if statistics reporting is enabled, to gauge demand for these features.
knz
force-pushed
the
20181019-metrics-more
branch
from
64db58d
to
df3712a
Compare
BramGruneir
approved these changes
Oct 19, 2018
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, 3 of 3 files at r2, 2 of 2 files at r3, 3 of 3 files at r4.
Reviewable status:complete! 0 of 0 LGTMs obtained (and 1 stale)
|
thanks bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Oct 21, 2018
31635: sql/parser: add missing telemetry for unimplemented features r=knz a=knz Requested by @awoods187. I feel really like a doofus for forgetting CREATE SCHEMA the first time around given that we have a lot of focus on it... Co-authored-by: Raphael 'kena' Poss <knz@cockroachlabs.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requested by @awoods187.
I feel really like a doofus for forgetting CREATE SCHEMA the first time around given that we have a lot of focus on it...