release-2.1: assorted missing telemetry #31638
Conversation
|
This change is |
knz
force-pushed
the
backport2.1-31635-31637
branch
from
223bbde
to
e05f15a
Compare
knz
force-pushed
the
backport2.1-31635-31637
branch
2 times, most recently
from
4f5e166
to
5275f26
Compare
| @@ -8355,6 +8376,7 @@ unreserved_keyword: | |||
| | DAY | |||
| | DEALLOCATE | |||
| | DELETE | |||
| | DEFERRED | |||
There was a problem hiding this comment.
Grammar changes including new keywords after RC1? I think this missed the cutoff and needs to wait for 2.2. Telemetry work really needs to be planned as a part of the main development cycle; it's not something we can do post-beta when we're only supposed to be making stability-improving changes. @awoods187
There was a problem hiding this comment.
This is an unreserved keyword. It doesn't change the set of queries that will be accepted nor the set of queries that produce errors.
|
@bdarnell it wasn't planned this late in the cycle it was a minor oversight. It's really important for us to have good telemetry in the initial major release because many users don't upgrade to point releases--or at least not as frequently as we urge them to do so. |
knz
force-pushed
the
backport2.1-31635-31637
branch
from
5275f26
to
5e189d5
Compare
|
@BramGruneir can you review this PR today? This may be good to get into 2.1.1. |
There was a problem hiding this comment.
As long as this has @bdarnell's blessing.
Reviewed 2 of 2 files at r1, 3 of 3 files at r2, 2 of 2 files at r3, 3 of 3 files at r4, 4 of 4 files at r5, 4 of 4 files at r6.
Reviewable status:complete! 1 of 0 LGTMs obtained
|
let's definitely get this into 2.1.1 cc @BramGruneir |
|
Got greenlight offline from Bram. |
Release note (sql change): Attempts to use `CREATE/DROP SCHEMA` will now be collected as telemetry if statistics reporting is enabled, to gauge demand for user-defined schemas.
Release note (sql change): Attempts to use `DEFERRABLE` and other constraint deferrability options will now be collected as telemetry if statistics reporting is enabled, to gauge demand for tuning time of constraint checking.
Release note (sql change): Attempts to use `CREATE TABLE (LIKE...)` will now be collected as telemetry if statistics reporting is enabled, to gauge demand for this feature.
Release note (sql change): Attempts to use `CREATE TABLE ... WITH` will now be collected as telemetry if statistics reporting is enabled, to gauge demand for these features.
Prior to this patch, if any built-in function was producing a non-pgerror error object it would be reported in telemetry as `othererror.eval.go:3573`. This patch fixes this by ensuring the function name is included and the error reported as a pg "data error", e.g. `othererror.22000.somefunction()`. In addition, this patch extends the connExecutor error handling code to always include a `pgerror.Error`'s `InternalCommand` in telemetry if set, not just when the code is "internal error" or "syntax error". Release note (sql change): CockroachDB will now include the name of the SQL built-in function in collected statistics upon evaluation errors.
The JDBC driver and perhaps others commonly try to use the "fetch limit" parameter, which is yet unsupported in CockroachDB (cockroachdb#4035). This patch adds telemetry to gauge demand. Release note (sql change): attempts by client apps to use the unsupported "fetch limit" parameter (e.g. via JDBC) will now be captured in telemetry if statistics reporting is enabled, to gauge support for this feature.
knz
force-pushed
the
backport2.1-31635-31637
branch
from
5e189d5
to
b01b612
Compare
|
Rebased, merging on green. |
|
TC is wedged on a stress test somehow... |
|
ah, it is done. |
Backport:
Please see individual PRs for details.
/cc @cockroachdb/release