Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-2.1: assorted missing telemetry #31638

Merged
merged 6 commits into from
Nov 12, 2018
Merged

release-2.1: assorted missing telemetry #31638

merged 6 commits into from
Nov 12, 2018

Commits on Nov 12, 2018

  1. sql/parser: ensure that CREATE/DROP SCHEMA attempts land in stats 

    Release note (sql change): Attempts to use `CREATE/DROP SCHEMA` will
now be collected as telemetry if statistics reporting is enabled, to
gauge demand for user-defined schemas.
    @knz
    knz committed Nov 12, 2018
    Configuration menu
    Copy the full SHA
    725a937 View commit details
    Browse the repository at this point in the history

  2. sql/parser: mark constraint deferrability options for telemetry 

    Release note (sql change): Attempts to use `DEFERRABLE` and other
constraint deferrability options will now be collected as telemetry if
statistics reporting is enabled, to gauge demand for tuning time of
constraint checking.
    @knz
    knz committed Nov 12, 2018
    Configuration menu
    Copy the full SHA
    107fc59 View commit details
    Browse the repository at this point in the history

  3. sql/parser: track CREATE TABLE (LIKE ...) for telemetry 

    Release note (sql change): Attempts to use `CREATE TABLE (LIKE...)`
will now be collected as telemetry if statistics reporting is enabled,
to gauge demand for this feature.
    @knz
    knz committed Nov 12, 2018
    Configuration menu
    Copy the full SHA
    a203fc1 View commit details
    Browse the repository at this point in the history

  4. sql/parser: track usage of CREATE TABLE ... WITH in telemetry 

    Release note (sql change): Attempts to use `CREATE TABLE ... WITH`
will now be collected as telemetry if statistics reporting is enabled,
to gauge demand for these features.
    @knz
    knz committed Nov 12, 2018
    Configuration menu
    Copy the full SHA
    2faa071 View commit details
    Browse the repository at this point in the history

  5. sql,telemetry: report built-in function name in eval failures 

    Prior to this patch, if any built-in function was producing a
non-pgerror error object it would be reported in telemetry as
`othererror.eval.go:3573`.

This patch fixes this by ensuring the function name is included and
the error reported as a pg "data error",
e.g. `othererror.22000.somefunction()`.

In addition, this patch extends the connExecutor error handling code
to always include a `pgerror.Error`'s `InternalCommand` in telemetry
if set, not just when the code is "internal error" or "syntax error".

Release note (sql change): CockroachDB will now include the name of
the SQL built-in function in collected statistics upon evaluation
errors.
    @knz
    knz committed Nov 12, 2018
    Configuration menu
    Copy the full SHA
    00ca6cb View commit details
    Browse the repository at this point in the history

  6. pgwire: add telemetry for fetch limits 

    The JDBC driver and perhaps others commonly try to use the "fetch
limit" parameter, which is yet unsupported in
CockroachDB (cockroachdb#4035). This patch adds telemetry to gauge demand.

Release note (sql change): attempts by client apps to use the
unsupported "fetch limit" parameter (e.g. via JDBC) will now be
captured in telemetry if statistics reporting is enabled, to gauge
support for this feature.
    @knz
    knz committed Nov 12, 2018
    Configuration menu
    Copy the full SHA
    b01b612 View commit details
    Browse the repository at this point in the history