builtins: add in unimplemented spatial builtins #53556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
@sumeerbhola mind taking a look at this today? |
sumeerbhola
approved these changes
Aug 31, 2020
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained
|
bors r=sumeerbhola tftr! |
|
Build failed (retrying...): |
|
bors r- |
|
Canceled. |
otan
force-pushed
the
telemetry_unimpl_geo
branch
from
88b6041
to
4732d3b
Compare
|
bors r=sumeerbhola |
|
bors r- |
|
Canceled. |
otan
force-pushed
the
telemetry_unimpl_geo
branch
from
4732d3b
to
5ee105c
Compare
|
sorry, more and more builtins getting in. bors r=sumeerbhola |
|
one more builtin from open source... bors r- |
|
Canceled. |
This adds telemetry to remaining unused functions, as well as displaying the issue number when someone attempts to use an unimplemented function. Also changed the wording of the error message to be a little more friendly. Release justification: low risk, high benefit changes Release note: None
otan
force-pushed
the
telemetry_unimpl_geo
branch
from
5ee105c
to
4bc78c4
Compare
|
bors r=sumeerbhola |
|
This PR was included in a batch that was canceled, it will be automatically retried |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds telemetry to remaining unused functions, as well as displaying
the issue number when someone attempts to use an unimplemented function.
Also changed the wording of the error message to be a little more
friendly.
Release justification: low risk, high benefit changes
Release note: None