builtins: implement ST_MemCollect and ST_MemUnion #53708
Conversation
|
Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR. My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
|
This change is |
|
CC @otan |
| "st_union": makeSTUnionBuiltin(), | ||
| "st_memunion": makeSTUnionBuiltin(), | ||
| "st_collect": makeSTCollectBuiltin(), | ||
| "st_memcollect": makeSTCollectBuiltin(), |
There was a problem hiding this comment.
you can re-use the alias stuff for these: https://github.com/cockroachdb/cockroach/blob/master/pkg/sql/sem/builtins/geo_builtins.go#L4622
also #53556 is in the queue and you'll probably have to rebase over the top of them.
thanks!
There was a problem hiding this comment.
oh nvm you can't :P! hold out on the rebase then, if that's ok. i can do it for you if you prefer.
There was a problem hiding this comment.
I'm off to bed shortly, so feel free to rebase, otherwise I'll get to it tomorrow.
These are implemented as aliases for ST_Collect and ST_Union. In PostGIS these are memory-optimized versions, but for now it should be sufficient to simply make them functional. Release justification: low risk, high benefit changes to existing functionality Release note (sql change): Implement the geometry aggregate builtins `ST_MemCollect` and `ST_MemUnion`.
|
bors r+ |
|
Build succeeded: |
These are implemented as aliases for ST_Collect and ST_Union. In PostGIS
these are memory-optimized versions, but for now it should be sufficient
to simply make them functional.
Release justification: low risk, high benefit changes to existing functionality
Release note (sql change): Implement the geometry aggregate builtins
ST_MemCollectandST_MemUnion.Closes #48984.
Closes #48986.