Merge pull request #7911 from kenjis/fix-ReflectionHelper-setValue

[PHP 8.3] refactor: ReflectionProperty::setValue() signature deprecation
codeigniter4 · Sep 8, 2023 · b38cec4 · b38cec4
2 parents eb1d5e0 + ddd2317
commit b38cec4
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/system/Test/ReflectionHelper.php b/system/Test/ReflectionHelper.php
@@ -74,7 +74,12 @@ private static function getAccessibleRefProperty($obj, $property)
     public static function setPrivateProperty($obj, $property, $value)
     {
         $refProperty = self::getAccessibleRefProperty($obj, $property);
-        $refProperty->setValue($obj, $value);
+
+        if (is_object($obj)) {
+            $refProperty->setValue($obj, $value);
+        } else {
+            $refProperty->setValue(null, $value);
+        }
     }
 
     /**

diff --git a/tests/system/CLI/CLITest.php b/tests/system/CLI/CLITest.php
@@ -438,13 +438,13 @@ public function testWindow(): void
     {
         $height = new ReflectionProperty(CLI::class, 'height');
         $height->setAccessible(true);
-        $height->setValue(null);
+        $height->setValue(null, null);
 
         $this->assertIsInt(CLI::getHeight());
 
         $width = new ReflectionProperty(CLI::class, 'width');
         $width->setAccessible(true);
-        $width->setValue(null);
+        $width->setValue(null, null);
 
         $this->assertIsInt(CLI::getWidth());
     }