Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PHP 8.3] refactor: ReflectionProperty::setValue() signature deprecation #7911

Merged
merged 2 commits into from
Sep 8, 2023
Merged

[PHP 8.3] refactor: ReflectionProperty::setValue() signature deprecation #7911

merged 2 commits into from
Sep 8, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Sep 8, 2023 •
edited
Loading

Description
See #7850

  • update deprecated code in PHP 8.3

E.g.,

 1) CodeIgniter\CLI\CLITest::testWindow
ErrorException: Calling ReflectionProperty::setValue() with a single argument is deprecated

/home/runner/work/CodeIgniter4/CodeIgniter4/tests/system/CLI/CLITest.php:441

See https://github.com/codeigniter4/CodeIgniter4/actions/runs/6035726283/job/16376653028?pr=7886

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis
fix: deprecated code in PHP 8.3
4364573 
Calling ReflectionProperty::setValue() with a 1st argument which is not null or an object is deprecated
@kenjis
test: fix deprecated code in PHP 8.3
ddd2317
@kenjis kenjis mentioned this pull request Aug 31, 2023
Closed
6 tasks
@kenjis kenjis changed the title refactor: ReflectionProperty::setValue() signature deprecation in PHP 8.3 [PHP 8.3] refactor: ReflectionProperty::setValue() signature deprecation Sep 8, 2023
@kenjis kenjis added the refactor Pull requests that refactor code label Sep 8, 2023
@samsonasik samsonasik merged commit b38cec4 into codeigniter4:develop Sep 8, 2023
52 checks passed
@samsonasik
Copy link
Member

Thank you @kenjis

@kenjis kenjis deleted the fix-ReflectionHelper-setValue branch September 8, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsonasik samsonasik samsonasik approved these changes

Assignees
No one assigned
Labels
refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @samsonasik