Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Model::insertBatch() causes error to non auto increment table #7759

Merged
merged 3 commits into from
Aug 4, 2023
Merged

fix: Model::insertBatch() causes error to non auto increment table #7759

merged 3 commits into from
Aug 4, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Aug 1, 2023 •
edited
Loading

Description
Fixes #7744

CodeIgniter\Database\Exceptions\DataException : There is no primary key defined when trying to make insertBatch.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Aug 1, 2023
@kenjis kenjis marked this pull request as draft August 1, 2023 01:11
@kenjis kenjis force-pushed the fix-model-insertBatch-noAutoIncrement branch from a143910 to 6cd704d Compare August 1, 2023 01:33
@kenjis
fix: Model::insertBatch() to non auto-increment table causes error
a2c4749 
CodeIgniter\Database\Exceptions\DataException : There is no primary key defined when trying to make insertBatch.
@kenjis kenjis marked this pull request as ready for review August 1, 2023 01:52
This was referenced Aug 1, 2023
Merged
Closed
MGatner
MGatner approved these changes Aug 3, 2023
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥵

@kenjis kenjis merged commit dd7a139 into codeigniter4:develop Aug 4, 2023
50 checks passed
@kenjis kenjis deleted the fix-model-insertBatch-noAutoIncrement branch August 4, 2023 00:37
@kenjis kenjis added the database Issues or pull requests that affect the database layer label Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them database Issues or pull requests that affect the database layer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Model cannot insertBatch when $useAutoIncrement is false
2 participants
@kenjis @MGatner