Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove Model::$tempPrimaryKeyValue #7760

Merged
merged 1 commit into from
Aug 6, 2023
Merged

refactor: remove Model::$tempPrimaryKeyValue #7760

merged 1 commit into from
Aug 6, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Aug 1, 2023 •
edited
Loading

Needs #7759

Description
Follow-up #6827

#7759 makes $tempPrimaryKeyValue unnecessary.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the refactor Pull requests that refactor code label Aug 1, 2023
@kenjis kenjis marked this pull request as draft August 1, 2023 02:02
@MGatner
Copy link
Member

MGatner commented Aug 3, 2023

Awaiting rebase.

@kenjis kenjis force-pushed the refactor-model-insert-noAutoIncrement branch from e386978 to b9dd62d Compare August 4, 2023 04:38
@kenjis kenjis marked this pull request as ready for review August 4, 2023 04:39
@kenjis kenjis merged commit eaa8f1a into codeigniter4:develop Aug 6, 2023
51 checks passed
@kenjis kenjis deleted the refactor-model-insert-noAutoIncrement branch August 6, 2023 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @MGatner