Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update Backward Compatibility Notes #7902

Merged

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Sep 6, 2023

Description
I would like to remove depreciated features to clean up the code. E.g. #7903

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • User guide updated
  • [] Conforms to style guide

@kenjis kenjis added the documentation Pull requests for documentation only label Sep 6, 2023
@@ -13,7 +13,8 @@ However, the code is not mature and bug fixes may break compatibility in minor r
What are not Breaking Changes
*****************************

- The deprecated Config items are not covered by backwards compatibility (BC) promise. It may be removed in the next
**minor** version or later.
- The deprecated items are not covered by backwards compatibility (BC) promise. It may be removed in the next next
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate words

Suggested change
- The deprecated items are not covered by backwards compatibility (BC) promise. It may be removed in the next next
- The deprecated items are not covered by backwards compatibility (BC) promise. It may be removed in the next

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it is not duplicate. Not the next, but next of the next. What should I put?
See the example after that.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe in the second minor release? However, I have no problem with understanding the current one.

Copy link
Member

@MGatner MGatner Sep 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are all fine. We're also all developers, so "in the n+2 minor release" 🤣
The example makes it clear so I'm not worried about the terminology.

@kenjis kenjis merged commit ee1f01f into codeigniter4:develop Sep 13, 2023
1 check passed
@kenjis kenjis deleted the docs-update-backward_compatibility_notes branch September 13, 2023 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests for documentation only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants