Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: always use multiple filters #7903

Merged
merged 8 commits into from
Sep 14, 2023
Merged

refactor: always use multiple filters #7903

merged 8 commits into from
Sep 14, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Sep 6, 2023 •
edited
Loading

Description

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added breaking change Pull requests that may break existing functionalities 4.5 labels Sep 6, 2023
@kenjis kenjis marked this pull request as draft September 6, 2023 02:55
@kenjis kenjis added the refactor Pull requests that refactor code label Sep 6, 2023
@kenjis kenjis mentioned this pull request Sep 6, 2023
Merged
2 tasks
@kenjis kenjis added the docs needed Pull requests needing documentation write-ups and/or revisions. label Sep 6, 2023
@kenjis kenjis force-pushed the multipleFilters-default branch 2 times, most recently from 9d5be64 to 0174873 Compare September 13, 2023 06:11
@kenjis
Copy link
Member Author

kenjis commented Sep 13, 2023

Rebased and added docs.

@kenjis kenjis marked this pull request as ready for review September 13, 2023 06:11
@kenjis kenjis removed the docs needed Pull requests needing documentation write-ups and/or revisions. label Sep 13, 2023
@kenjis kenjis marked this pull request as draft September 13, 2023 06:16
@kenjis kenjis marked this pull request as ready for review September 13, 2023 06:28
@MGatner
Copy link
Member

MGatner commented Sep 13, 2023

Hmm same Coveralls issue is happening here now.

PHP Fatal error: Uncaught Error: Class "Config\Autoload" not found in /home/runner/work/CodeIgniter4/CodeIgniter4/system/Test/Mock/MockAutoload.php:16

MGatner
MGatner approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice docs

@kenjis kenjis merged commit 28fe6ff into codeigniter4:4.5 Sep 14, 2023
60 of 61 checks passed
@kenjis kenjis deleted the multipleFilters-default branch September 14, 2023 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
4.5 breaking change Pull requests that may break existing functionalities refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @MGatner