feat: HTTP method-aware web page caching #8364
Conversation
kenjis
force-pushed
the
page-cache-http-method
branch
2 times, most recently
from
da37c9c
to
d182491
Compare
system/Filters/PageCache.php
Outdated
| @@ -65,6 +66,10 @@ public function after(RequestInterface $request, ResponseInterface $response, $a | |||
| { | |||
| assert($request instanceof CLIRequest || $request instanceof IncomingRequest); | |||
|
|
|||
| if ($this->isNotCacheableMethod($request)) { | |||
There was a problem hiding this comment.
So what's cachable? GET and HEAD? If that's all, and HEAD isn't something we really need to worry about caching, wouldn't it be simpler to just check if $request->getMethod() !== 'get'?
There was a problem hiding this comment.
ResponseCache also caches the headers, so in theory, it can be useful for HEAD... however, as I mentioned in my comment, I would make it configurable and stick to the GET by default.
There was a problem hiding this comment.
So what's cachable?
GET, HEAD, POST, PATCH, CLI.
But a dev must put $this->cachePage($n); in controller.
There was a problem hiding this comment.
But a dev must put $this->cachePage($n); in controller.
Ok, that changes a lot.
There was a problem hiding this comment.
I dropped the check.
To begin with, page caching must be specified by developers in controllers.
There is no need for the filter to dare to check the HTTP method to limit the cache functionality.
Besides, if a developer wants to determine to enable caching by HTTP method, they can customize the filter.
|
Enabling caching for POST requests by default is rather controversial. I would be in favor of adding a config for this. While I can imagine a scenario where we want to cache the POST response, the most common action for POST requests (which change the state of the application) will be to respond with new content every time. |
|
Ah, strictly speaking, the current this PR has a breaking change? |
kenjis
force-pushed
the
page-cache-http-method
branch
from
d182491
to
c6a9112
Compare
kenjis
force-pushed
the
page-cache-http-method
branch
from
c6a9112
to
0c01fbc
Compare
|
I forgot to document. Added. |
kenjis
force-pushed
the
page-cache-http-method
branch
from
2715695
to
5f7c7d5
Compare
|
LGTM |
Description
Closes #8363
Enhancement to https://codeigniter4.github.io/CodeIgniter4/general/caching.html
The current issue:
If we use RESTful Resource Handling, operation Create and List have the same URI.
https://codeigniter4.github.io/CodeIgniter4/incoming/restful.html#presenter-controller-comparison
If we enable page caching to List (GET), Create (POST) will return the cached List response.
Checklist: