Toyota: DBC message for SecOC longitudinal control #1337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Long control is out of scope for initial RAV4 Prime support in #1287, but in the course of validation, we identified the new ACC control message.
Much like STEERING_LTA now has a SecOC-signed companion STEERING_LTA_2 with mostly just the actuation commands moved, ACC_CONTROL now has a SecOC-signed companion ACC_CONTROL_2 with just the acceleration value moved.
The message comes in from the bus 2 side, just like ACC_CONTROL, and the SecOC solve should be generally applicable. Long control is almost certainly possible with a few hours spent on control and Panda safety.