Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toyota: 2021-23 RAV4 Prime #1287

Merged
merged 61 commits into from
Oct 4, 2024
Merged

Conversation

jyoung8607
Copy link
Collaborator

@jyoung8607 jyoung8607 commented Sep 26, 2024

Credit to @pd0wm, just bringing commaai/openpilot#31179 current after the refactor.

  • Find a way to pass the SecOC key down from openpilot
  • Don't log SecOC parameter (see mapbox token implementation)
  • UI warning for missing SecOC key
  • Make alt messages common between SecOC cars?
  • Look at remaining TODOs from Willem's work
  • Move SecOC implementation to a common area
  • Tests for SecOC? TBD later

TODO in a future PR:

  • Refactor SecOC module API to handle reset/trip/counter state internally
  • Allow storing multiple SecOC keys, by VIN

@jyoung8607 jyoung8607 mentioned this pull request Sep 30, 2024
@jyoung8607 jyoung8607 marked this pull request as ready for review October 2, 2024 03:14
@jyoung8607
Copy link
Collaborator Author

This should be G2G after the pandacan reference becomes available to update.

@jyoung8607
Copy link
Collaborator Author

jyoung8607 commented Oct 4, 2024

@sshane What do you think about capping MAC fail logging like this? Seems unwise to cloudlog fails at dozens/sec indefinitely when someone starts up with a wrong/missing key, but not sure we have similar limits for counter/checksum fails. I do want to know if it happens during a drive, and I want to know if it happens sporadically during key reset/rollover, etc.

@sshane
Copy link
Contributor

sshane commented Oct 4, 2024

Seems fine

@jyoung8607 jyoung8607 changed the title Toyota: 2021+ RAV4 Prime Toyota: 2021-23 RAV4 Prime Oct 4, 2024
@jyoung8607 jyoung8607 merged commit c908585 into commaai:master Oct 4, 2024
5 checks passed
@jyoung8607 jyoung8607 deleted the toyota-secoc branch October 4, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants