swaglog: enable type-checked against format string. #29096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
failed to pass the checks. need correct the format string in rednose : commaai/rednose#31 |
deanlee
force-pushed
the
log_check_fmt
branch
5 times, most recently
from
4e516e8
to
a88a75c
Compare
| @@ -390,7 +390,7 @@ kj::Array<capnp::word> UbloxMsgParser::parse_glonass_ephemeris(ubx_t::rxm_sfrbx_ | |||
| eph.setP4(data->p4()); | |||
| eph.setSvURA(glonass_URA_lookup.at(data->f_t())); | |||
| if (msg->sv_id() != data->n()) { | |||
| LOGE("SV_ID != SLOT_NUMBER: %d %d", msg->sv_id(), data->n()); | |||
| LOGE("SV_ID != SLOT_NUMBER: %d %" PRIu64, msg->sv_id(), data->n()); | |||
There was a problem hiding this comment.
use llu will report error on my laptop. the uint64_t is not the same as unsigned long long. https://stackoverflow.com/questions/32198368/unsigned-long-long-conflict-with-uint64-t
the PRIu64 can correctly format uint64_t as lu or llu on different platforms
There was a problem hiding this comment.
another way is use llu, and convert uint64_t to (unsigned long long):
LOGE("SV_ID != SLOT_NUMBER: %d %llu", msg->sv_id(), (unsigned long long)data->n());
opened at : commaai/rednose#31 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enable type-check & correct format string.
added a macro
SWAG_LOG_CHECK_FMTto causes the compiler to check the arguments in calls tocloudlogfor consistency with theprintfstyle format string argument: