Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IsoTpParallelQuery: extend timeout for every frame type #29654

Merged
merged 4 commits into from
Aug 26, 2023
Merged

IsoTpParallelQuery: extend timeout for every frame type #29654

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0b016fd
recv returns updated
sshane Aug 26, 2023
910c2d9
bump panda
sshane Aug 26, 2023
18df9d8
bump
sshane Aug 26, 2023
cc9f8dc
bump
sshane Aug 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion panda
Open in desktop
Submodule panda updated 2 files
+9 −0 board/jungle/main.c
+7 −5 python/uds.py
6 changes: 3 additions & 3 deletions selfdrive/car/isotp_parallel_query.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,14 +104,14 @@ def get_data(self, timeout, total_timeout=60.):

for tx_addr, msg in msgs.items():
try:
dat, rx_in_progress = msg.recv()
dat, updated = msg.recv()
except Exception:
cloudlog.exception(f"Error processing UDS response: {tx_addr}")
request_done[tx_addr] = True
continue

# Extend timeout for each consecutive ISO-TP frame to avoid timing out on long responses
if rx_in_progress:
# Extend timeout for each valid ISO-TP frame to avoid timing out on long responses
if updated:
addrs_responded.add(tx_addr)
response_timeouts[tx_addr] = time.monotonic() + timeout

Expand Down
Loading